Re: [PATCH v2 22/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

From: "Bjørn Mork" <bjorn@mork.no>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Roger Quadros <rogerq@ti.com>,
	balbi@ti.com, keshava_mgowda@ti.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 22/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure
Date: Mon, 03 Dec 2012 08:48:45 +0100	[thread overview]
Message-ID: <87ehj7y3s2.fsf@nemi.mork.no> (raw)
In-Reply-To: <50BB8B78.9010207@mvista.com> (Sergei Shtylyov's message of "Sun, 02 Dec 2012 21:10:16 +0400")

Sergei Shtylyov <sshtylyov@mvista.com> writes:
> On 28-11-2012 18:49, Roger Quadros wrote:
>>   		ret = clk_set_parent(omap->utmi_clk[0],
>>   					omap->xclk60mhsp1_ck);
>>   		if (ret != 0)
>> -			dev_err(dev, "xclk60mhsp1_ck set parent"
>> +			dev_dbg(dev, "xclk60mhsp1_ck set parent"
>
>    Need space at the end of this substring, else you get "parentfailed"
>
>>   				"failed error:%d\n", ret);

Wouldn't it be better to change all these to conform with
Documentation/CodingStyle when touching them anyway?  That would make
the missing space problem obvious as well as making the messages
greppable.

From Chapter 2: Breaking long lines and strings:

"However, never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html