Re: [PATCH 5/6] drm/doc: diagram for mode objects and properties

From: Eric Anholt <eric@anholt.net>
To: linux-doc@vger.kernel.org
Cc: Manasi Navare <manasi.d.navare@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 5/6] drm/doc: diagram for mode objects and properties
Date: Tue, 28 Feb 2017 15:40:15 -0800	[thread overview]
Message-ID: <87fuix3mw0.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170228171319.1786-6-daniel.vetter@ffwll.ch>

[-- Attachment #1.1: Type: text/plain, Size: 1257 bytes --]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> Resulted in confusion a few times in the past.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  Documentation/gpu/drm-kms.rst | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
> index 17a4cd5b14fd..20378881445f 100644
> --- a/Documentation/gpu/drm-kms.rst
> +++ b/Documentation/gpu/drm-kms.rst

> +The base structure for all KMS objects is :c:type:`struct drm_mode_object
> +<drm_mode_object>`. One of the base services is provides is tracking properties,

"it provides"?

> +which are especially important for the atomic IOCTL (see `Atomic Mode
> +Setting`_). The somewhat surprising part here is that properties are not
> +directly instantiated on each object, but free-standing mode objects themselves,
> +represented by :c:type:`struct drm_property <drm_property>`, which only specify
> +the type and value range of a property. Any given property can be attached
> +multiple times to different objects using :c:func:`drm_object_attach_property()
> +<drm_object_attach_property>`.
> +

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel