From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH 1/6] ASoC: audio-graph-card2.c: use of_property_read_u32() for rate
Date: Fri, 1 Jul 2022 05:18:14 +0000 [thread overview]
Message-ID: <87h741s961.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87ilohs96p.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Audio Graph Card2 is using of_get_property(), but it should use
of_property_read_u32() to getting rate. Otherwise the setting will be
strange value. This patch fixup it.
Fixes: c3a15c92a67b701 ("ASoC: audio-graph-card2: add Codec2Codec support")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/generic/audio-graph-card2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c
index d34b29a49268..8e0628e6f2a0 100644
--- a/sound/soc/generic/audio-graph-card2.c
+++ b/sound/soc/generic/audio-graph-card2.c
@@ -856,7 +856,7 @@ int audio_graph2_link_c2c(struct asoc_simple_priv *priv,
struct device_node *port0, *port1, *ports;
struct device_node *codec0_port, *codec1_port;
struct device_node *ep0, *ep1;
- u32 val;
+ u32 val = 0;
int ret = -EINVAL;
/*
@@ -880,7 +880,8 @@ int audio_graph2_link_c2c(struct asoc_simple_priv *priv,
ports = of_get_parent(port0);
port1 = of_get_next_child(ports, lnk);
- if (!of_get_property(ports, "rate", &val)) {
+ of_property_read_u32(ports, "rate", &val);
+ if (!val) {
struct device *dev = simple_priv_to_dev(priv);
dev_err(dev, "Codec2Codec needs rate settings\n");
--
2.25.1
next prev parent reply other threads:[~2022-07-01 5:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 5:17 [PATCH 0/6] ASoC: audio-graph-card2.c: make Codec2Codec settings optional Kuninori Morimoto
2022-07-01 5:18 ` Kuninori Morimoto [this message]
2022-07-01 5:18 ` [PATCH 2/6] " Kuninori Morimoto
2022-07-01 5:18 ` [PATCH 3/6] ASoC: audio-graph-card2.c: remove pre-alloced Codec2Codec space Kuninori Morimoto
2022-07-01 5:18 ` [PATCH 4/6] ASoC: audio-graph-card2-custom-sample.dtsi: add verbose explanation Kuninori Morimoto
2022-07-01 5:18 ` [PATCH 5/6] ASoC: simple-card-utils.c: ignore Codec2Codec setting if it already have Kuninori Morimoto
2022-07-01 5:18 ` [PATCH 6/6] ASoC: simple-card-utils.c: care Codec2Codec vs DPCM:BE Kuninori Morimoto
2022-07-08 20:47 ` [PATCH 0/6] ASoC: audio-graph-card2.c: make Codec2Codec settings optional Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h741s961.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.