From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH 16/17] ASoC: cleanup dai / component active code
Date: 11 May 2020 14:57:51 +0900 [thread overview]
Message-ID: <87imh38140.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <875zd39frp.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
No one is using dai->active, snd_soc_component_is_active().
Let's remove these.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
include/sound/soc-component.h | 6 ------
include/sound/soc-dai.h | 2 --
sound/soc/soc-pcm.c | 1 -
3 files changed, 9 deletions(-)
diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index 29b0c2c1d2db..cbb7255c8e27 100644
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -390,12 +390,6 @@ static inline void *snd_soc_component_get_drvdata(struct snd_soc_component *c)
return dev_get_drvdata(c->dev);
}
-static inline bool snd_soc_component_is_active(
- struct snd_soc_component *component)
-{
- return component->active != 0;
-}
-
/* component pin */
int snd_soc_component_enable_pin(struct snd_soc_component *component,
const char *pin);
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
index 887575d59e31..502aaeb561a0 100644
--- a/include/sound/soc-dai.h
+++ b/include/sound/soc-dai.h
@@ -351,8 +351,6 @@ struct snd_soc_dai {
/* DAI runtime info */
unsigned int stream_active[SNDRV_PCM_STREAM_LAST + 1]; /* usage count */
- unsigned int active;
-
struct snd_soc_dapm_widget *playback_widget;
struct snd_soc_dapm_widget *capture_widget;
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 420595356111..0eae9ab2a2ea 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -266,7 +266,6 @@ static void snd_soc_runtime_action(struct snd_soc_pcm_runtime *rtd,
for_each_rtd_dais(rtd, i, dai) {
dai->stream_active[stream] += action;
- dai->active += action;
snd_soc_component_activity(dai->component) += action;
}
}
--
2.17.1
next prev parent reply other threads:[~2020-05-11 6:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 5:55 [PATCH 00/17] ASoC: cleanup DAI/Component activity Kuninori Morimoto
2020-05-11 5:56 ` [PATCH 01/17] ASoC: soc-dai: add snd_soc_dai_activity() Kuninori Morimoto
2020-05-11 22:37 ` Ranjani Sridharan
2020-05-11 22:42 ` Ranjani Sridharan
2020-05-11 5:56 ` [PATCH 02/17] ASoC: use snd_soc_dai/component_activity() Kuninori Morimoto
2020-05-11 22:44 ` Ranjani Sridharan
2020-05-11 23:53 ` Kuninori Morimoto
2020-05-12 0:55 ` Ranjani Sridharan
2020-05-12 4:06 ` Kuninori Morimoto
2020-05-11 5:56 ` [PATCH 03/17] ASoC: soc-dai: add snd_soc_component_activity() Kuninori Morimoto
2020-05-11 19:07 ` Pierre-Louis Bossart
2020-05-11 22:47 ` Ranjani Sridharan
2020-05-11 5:56 ` [PATCH 04/17] ASoC: atomel: use snd_soc_dai/component_activity() Kuninori Morimoto
2020-05-11 5:56 ` [PATCH 05/17] ASoC: bcm: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 06/17] ASoC: cirrus: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 07/17] ASoC: codecs: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 08/17] ASoC: fsl: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 09/17] ASoC: intel: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 10/17] ASoC: jz4740: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 11/17] ASoC: mediatek: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 12/17] ASoC: meson: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 13/17] ASoC: pxa: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 14/17] ASoC: ti: " Kuninori Morimoto
2020-05-11 5:57 ` [PATCH 15/17] ASoC: uniphier: " Kuninori Morimoto
2020-05-11 5:57 ` Kuninori Morimoto [this message]
2020-05-11 5:58 ` [PATCH 17/17] ASoC: soc-dai: add snd_soc_dai_stream_activity() Kuninori Morimoto
2020-05-11 8:12 ` kbuild test robot
2020-05-11 8:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imh38140.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.