Re: [PATCH for-9.0] qapi: drop unused QCryptoBlockCreateOptionsLUKS.detached-header

From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,  Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH for-9.0] qapi: drop unused QCryptoBlockCreateOptionsLUKS.detached-header
Date: Tue, 19 Mar 2024 17:06:07 +0100	[thread overview]
Message-ID: <87jzlyyzo0.fsf@pond.sub.org> (raw)
In-Reply-To: <20240319153908.194975-1-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Tue, 19 Mar 2024 15:39:08 +0000")

Daniel P. Berrangé <berrange@redhat.com> writes:

> The 'detached-header' field in QCryptoBlockCreateOptionsLUKS
> was left over from earlier patch iterations.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qapi/crypto.json | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 931c88e688..ad9e3d0297 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -226,8 +226,6 @@
>  # @iter-time: number of milliseconds to spend in PBKDF passphrase
>  #     processing.  Currently defaults to 2000. (since 2.8)
>  #
> -# @detached-header: create a detached LUKS header. (since 9.0)
> -#
>  # Since: 2.6
>  ##
>  { 'struct': 'QCryptoBlockCreateOptionsLUKS',
> @@ -237,8 +235,7 @@
>              '*ivgen-alg': 'QCryptoIVGenAlgorithm',
>              '*ivgen-hash-alg': 'QCryptoHashAlgorithm',
>              '*hash-alg': 'QCryptoHashAlgorithm',
> -            '*iter-time': 'int',
> -            '*detached-header': 'bool'}}
> +            '*iter-time': 'int' }}
>  
>  ##
>  # @QCryptoBlockOpenOptions:

Glad you caught this in time.

Acked-by: Markus Armbruster <armbru@redhat.com>