Re: [PATCH RFC v1] stash: implement '--staged' option for 'push' and 'save'

From: Sergey Organov <sorganov@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Git List" <git@vger.kernel.org>,
	"Thomas Rast" <tr@thomasrast.ch>,
	"Denton Liu" <liu.denton@gmail.com>
Subject: Re: [PATCH RFC v1] stash: implement '--staged' option for 'push' and 'save'
Date: Tue, 12 Oct 2021 19:07:51 +0300	[thread overview]
Message-ID: <87k0ii446g.fsf@osv.gnss.ru> (raw)
In-Reply-To: <xmqqo87u777d.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 12 Oct 2021 05:34:14 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> More importantly...
>>
>> Whenever I think about a new "feature", I try to come up with a
>> story in which the feature effectively improves the end-user's life,
>> how it fits in the larger picture, and enables something that is
>> hard to do by combining other tools.
>>
>> The kind of "story" I would aim for is like this.  Suppose we were
>> selling not "git stash -S" but "git stash -k". ...
>

[...]

> So in short, I do not think I am strongly opposed to "git stash -S"
> existing, since I did find one use case story that it could be used,
> but I do think it is redundant and unnecessary.

Redundant? Yes. Unnecessary? Yes. Useful? Yes. ;-)

I took the steps to propose the new feature after yet another round of
"how do I quickly store this tiny bit of changes I just figured I need
for later, out of bunch of VIWIP changes?"

  git stash --staged

is exactly the (currently missing) answer for me, as I have pretty
interactive tool to stage diff chunks always handy.

What's your answer, I wonder?

That said, I'm also curious what story, if any, do you have for 'git
stash --patch', as exactly the same story should be applicable to
proposed 'git stash --staged', as far as I can see.

Thanks,
-- Sergey Organov