From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Prune inlines
Date: Wed, 13 Jan 2021 17:29:19 +0200 [thread overview]
Message-ID: <87k0sgsvn4.fsf@intel.com> (raw)
In-Reply-To: <20210113152224.29794-1-chris@chris-wilson.co.uk>
On Wed, 13 Jan 2021, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Remove all the manual inlines from non-critical sections in gt/
>
> add/remove: 2/0 grow/shrink: 0/3 up/down: 762/-1473 (-711)
> Function old new delta
> mi_set_context.isra - 602 +602
> write_dma_entry - 160 +160
> __set_pd_entry 214 69 -145
> clear_pd_entry 190 42 -148
> ring_request_alloc 2021 841 -1180
> Total: Before=1605086, After=1604375, chg -0.04%
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
> @@ -98,13 +98,13 @@ static inline void __timeline_mark_unlock(struct intel_context *ce,
>
> #else
>
> -static inline unsigned long __timeline_mark_lock(struct intel_context *ce)
> +static unsigned long __timeline_mark_lock(struct intel_context *ce)
> {
> return 0;
> }
>
> -static inline void __timeline_mark_unlock(struct intel_context *ce,
> - unsigned long flags)
> +static void __timeline_mark_unlock(struct intel_context *ce,
> + unsigned long flags)
> {
> }
I don't mind inlines for stubs, but probably doesn't make a difference.
> @@ -113,9 +114,10 @@ clear_pd_entry(struct i915_page_directory * const pd,
> {
> GEM_BUG_ON(atomic_read(px_used(pd)) == 0);
>
> - write_dma_entry(px_base(pd), idx, scratch->encode);
> - pd->entry[idx] = NULL;
> atomic_dec(px_used(pd));
> + pd->entry[idx] = NULL;
> +
> + write_dma_entry(px_base(pd), idx, scratch->encode);
With the changes in this hunk removed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-13 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 15:22 [Intel-gfx] [PATCH] drm/i915/gt: Prune inlines Chris Wilson
2021-01-13 15:29 ` Jani Nikula [this message]
2021-01-13 20:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-14 0:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0sgsvn4.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.