From: Markus Armbruster <armbru@redhat.com>
To: Andrey Shinkevich via <qemu-devel@nongnu.org>
Cc: kwolf@redhat.com, lvivier@redhat.com, thuth@redhat.com,
vsementsov@virtuozzo.com, qemu-block@nongnu.org, den@openvz.org,
mdroth@linux.vnet.ibm.com, mreitz@redhat.com,
pbonzini@redhat.com,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
dgilbert@redhat.com
Subject: Re: [PATCH v3 4/5] iotests: 129 don't check backup "busy"
Date: Tue, 02 Mar 2021 14:45:09 +0100 [thread overview]
Message-ID: <87lfb5llei.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1606484146-913540-5-git-send-email-andrey.shinkevich@virtuozzo.com> (Andrey Shinkevich via's message of "Fri, 27 Nov 2020 16:35:45 +0300")
Andrey Shinkevich via <qemu-devel@nongnu.org> writes:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> Busy is racy, job has it's "pause-points" when it's not busy. Drop this
> check.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/129 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> index 0e13244..3c22f64 100755
> --- a/tests/qemu-iotests/129
> +++ b/tests/qemu-iotests/129
> @@ -67,7 +67,6 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
> result = self.vm.qmp("stop")
> self.assert_qmp(result, 'return', {})
> result = self.vm.qmp("query-block-jobs")
> - self.assert_qmp(result, 'return[0]/busy', True)
> self.assert_qmp(result, 'return[0]/ready', False)
>
> def test_drive_mirror(self):
The same change has since made it to master as commit f9a6256b48
"iotests/129: Do not check @busy".
next prev parent reply other threads:[~2021-03-02 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 13:35 [PATCH v3 0/5] Increase amount of data for monitor to read Andrey Shinkevich via
2020-11-27 13:35 ` [PATCH v3 1/5] monitor: change function obsolete name in comments Andrey Shinkevich via
2021-03-02 13:45 ` Markus Armbruster
2020-11-27 13:35 ` [PATCH v3 2/5] monitor: drain requests queue with 'channel closed' event Andrey Shinkevich via
2021-03-02 13:53 ` Markus Armbruster
2021-03-02 15:25 ` Vladimir Sementsov-Ogievskiy
2021-03-02 16:32 ` Denis V. Lunev
2021-03-02 17:02 ` Vladimir Sementsov-Ogievskiy
2021-03-05 13:41 ` Markus Armbruster
2021-03-05 14:01 ` Vladimir Sementsov-Ogievskiy
2020-11-27 13:35 ` [PATCH v3 3/5] monitor: let QMP monitor track JSON message content Andrey Shinkevich via
2020-11-27 13:35 ` [PATCH v3 4/5] iotests: 129 don't check backup "busy" Andrey Shinkevich via
2021-03-02 13:45 ` Markus Armbruster [this message]
2020-11-27 13:35 ` [PATCH v3 5/5] monitor: increase amount of data for monitor to read Andrey Shinkevich via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfb5llei.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.