From: Thomas Gleixner <tglx@linutronix.de>
To: John Garry <john.garry@huawei.com>,
gregkh@linuxfoundation.org, rafael@kernel.org,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linuxarm@huawei.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, maz@kernel.org
Subject: Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc()
Date: Thu, 19 Nov 2020 19:09:37 +0100 [thread overview]
Message-ID: <87lfexp6am.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <b86af904-2288-8b53-7e99-e763b73987d0@huawei.com>
On Thu, Nov 19 2020 at 09:31, John Garry wrote:
>> 1) Interrupt does not exist. Definitely a full fail
>>
>> 2) Interrupt is already started up. Not a good idea on init() and
>> a clear fail.
>>
>> 3) Interrupt has already been switched to managed. Double init is not
>> really a good sign either.
>
> I just tested that and case 3) would be a problem. I don't see us
> clearing the managed flag when free'ing the interrupt. So with
> CONFIG_DEBUG_TEST_DRIVER_REMOVE=y, we attempt this affinity update
> twice, and error from the irqd_affinity_is_managed() check.
That means the interrupt is not deallocated and reallocated, which does
not make sense to me.
Thanks,
tglx
next prev parent reply other threads:[~2020-11-19 18:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:33 [PATCH v2 0/3] Support managed interrupts for platform devices John Garry
2020-10-28 12:33 ` [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-10-28 18:22 ` Thomas Gleixner
2020-11-02 17:32 ` John Garry
2020-11-02 20:35 ` Thomas Gleixner
2020-11-17 21:28 ` Thomas Gleixner
2020-11-18 11:34 ` John Garry
2020-11-18 20:38 ` Thomas Gleixner
2020-11-19 9:31 ` John Garry
2020-11-19 18:09 ` Thomas Gleixner [this message]
2020-11-19 19:56 ` John Garry
2020-11-19 21:03 ` Thomas Gleixner
2020-11-20 11:52 ` John Garry
2020-11-22 13:38 ` Marc Zyngier
2020-11-23 12:54 ` John Garry
2020-11-23 13:26 ` Marc Zyngier
2020-11-23 15:45 ` John Garry
2020-11-24 16:51 ` Marc Zyngier
2020-11-24 17:38 ` John Garry
2020-11-25 18:35 ` Marc Zyngier
2020-11-26 10:47 ` John Garry
2020-11-26 11:08 ` Marc Zyngier
2020-11-26 11:29 ` John Garry
2020-11-26 16:52 ` John Garry
2020-11-27 9:57 ` Marc Zyngier
2020-11-27 12:45 ` John Garry
2020-11-27 12:49 ` Marc Zyngier
2020-10-28 12:33 ` [PATCH v2 2/3] Driver core: platform: Add platform_get_irqs_affinity() John Garry
2020-10-28 12:33 ` [PATCH v2 3/3] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfexp6am.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.