From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Michael Roth <michael.roth@amd.com>, John Snow <jsnow@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly)
Date: Tue, 31 Aug 2021 16:28:39 +0200 [thread overview]
Message-ID: <87mtoxwuw8.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAMxuvaxLTknvV3k_J4OtTWB2MjL6tj_2AH-0=NV7QbZLwFwOWA@mail.gmail.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 31 Aug 2021 17:41:56 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> On Tue, Aug 31, 2021 at 4:38 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Markus Armbruster (12):
>> qapi: Simplify QAPISchemaIfCond's interface for generating C
>> qapi: Simplify how QAPISchemaIfCond represents "no condition"
>> tests/qapi-schema: Correct two 'if' conditionals
>> tests/qapi-schema: Demonstrate broken C code for 'if'
>> qapi: Fix C code generation for 'if'
>> qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()
>> qapi: Avoid redundant parens in code generated for conditionals
>> qapi: Use "not COND" instead of "!COND" for generated documentation
>> qapi: Use re.fullmatch() where appropriate
>> tests/qapi-schema: Hide OrderedDict in test output
>> qapi: Tweak error messages for missing / conflicting meta-type
>> qapi: Tweak error messages for unknown / conflicting 'if' keys
>>
>> scripts/qapi/common.py | 51 ++++++++++++++-----------
>> scripts/qapi/expr.py | 32 +++++++---------
>> scripts/qapi/gen.py | 6 +--
>> scripts/qapi/introspect.py | 6 +--
>> scripts/qapi/schema.py | 12 +++++-
>> scripts/qapi/types.py | 22 +++++------
>> scripts/qapi/visit.py | 14 +++----
>> tests/qapi-schema/bad-if-key.err | 2 +-
>> tests/qapi-schema/bad-if-keys.err | 2 +-
>> tests/qapi-schema/doc-good.json | 2 +-
>> tests/qapi-schema/doc-good.out | 6 +--
>> tests/qapi-schema/doc-good.txt | 8 ++--
>> tests/qapi-schema/double-type.err | 4 +-
>> tests/qapi-schema/enum-if-invalid.err | 2 +-
>> tests/qapi-schema/missing-type.err | 2 +-
>> tests/qapi-schema/qapi-schema-test.json | 9 +++--
>> tests/qapi-schema/qapi-schema-test.out | 31 ++++++++-------
>> tests/qapi-schema/test-qapi.py | 11 +++++-
>> 18 files changed, 118 insertions(+), 104 deletions(-)
>>
>>
> The first patch, you should apply isort
Will fix.
> The first patch, you should apply isort (we should have a check for that
> and linters I suppose).
John will get us there.
> Series:
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
next prev parent reply other threads:[~2021-08-31 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 12:37 [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly) Markus Armbruster
2021-08-31 12:37 ` [PATCH 01/12] qapi: Simplify QAPISchemaIfCond's interface for generating C Markus Armbruster
2021-08-31 12:37 ` [PATCH 02/12] qapi: Simplify how QAPISchemaIfCond represents "no condition" Markus Armbruster
2021-08-31 12:38 ` [PATCH 03/12] tests/qapi-schema: Correct two 'if' conditionals Markus Armbruster
2021-08-31 12:38 ` [PATCH 04/12] tests/qapi-schema: Demonstrate broken C code for 'if' Markus Armbruster
2021-08-31 12:38 ` [PATCH 05/12] qapi: Fix C code generation " Markus Armbruster
2021-08-31 12:38 ` [PATCH 06/12] qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond() Markus Armbruster
2021-08-31 12:38 ` [PATCH 07/12] qapi: Avoid redundant parens in code generated for conditionals Markus Armbruster
2021-08-31 12:38 ` [PATCH 08/12] qapi: Use "not COND" instead of "!COND" for generated documentation Markus Armbruster
2021-08-31 12:38 ` [PATCH 09/12] qapi: Use re.fullmatch() where appropriate Markus Armbruster
2021-08-31 12:38 ` [PATCH 10/12] tests/qapi-schema: Hide OrderedDict in test output Markus Armbruster
2021-08-31 12:38 ` [PATCH 11/12] qapi: Tweak error messages for missing / conflicting meta-type Markus Armbruster
2021-08-31 12:38 ` [PATCH 12/12] qapi: Tweak error messages for unknown / conflicting 'if' keys Markus Armbruster
2021-08-31 13:41 ` [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly) Marc-André Lureau
2021-08-31 14:28 ` Markus Armbruster [this message]
2021-09-15 14:50 ` John Snow
2021-09-15 15:08 ` Marc-André Lureau
2021-09-15 15:38 ` John Snow
2021-09-03 19:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtoxwuw8.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.