From: Felipe Balbi <balbi@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Jack Pham <jackp@codeaurora.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] usb: gadget: u_audio: clean up locking
Date: Thu, 07 Jan 2021 11:28:35 +0200 [thread overview]
Message-ID: <87mtxlayf0.fsf@kernel.org> (raw)
In-Reply-To: <20210106133652.512178-6-jbrunet@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Jerome Brunet <jbrunet@baylibre.com> writes:
> snd_pcm_stream_lock() is held when the ALSA .trigger() callback is called.
> The lock of 'struct uac_rtd_params' is not necessary since all its locking
> operation are done under the snd_pcm_stream_lock() too.
>
> Also, usb_request .complete() is called with irqs disabled, so saving and
> restoring the irqs is not necessary.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
This is nice!
Acked-by: Felipe Balbi <balbi@.kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
prev parent reply other threads:[~2021-01-07 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:36 [PATCH v2 0/5] usb: gadget: audio fixes and clean ups Jerome Brunet
2021-01-06 13:36 ` [PATCH v2 1/5] usb: gadget: u_audio: Free requests only after callback Jerome Brunet
2021-01-07 9:22 ` Felipe Balbi
2021-01-06 13:36 ` [PATCH v2 2/5] usb: gadget: f_uac2: reset wMaxPacketSize Jerome Brunet
2021-01-07 9:24 ` Felipe Balbi
2021-01-06 13:36 ` [PATCH v2 3/5] usb: gadget: u_audio: factorize ssize to alsa fmt conversion Jerome Brunet
2021-01-07 9:25 ` Felipe Balbi
2021-01-06 13:36 ` [PATCH v2 4/5] usb: gadget: u_audio: remove struct uac_req Jerome Brunet
2021-01-07 9:27 ` Felipe Balbi
2021-01-06 13:36 ` [PATCH v2 5/5] usb: gadget: u_audio: clean up locking Jerome Brunet
2021-01-07 9:28 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtxlayf0.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.