Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface

From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
	famz@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de,
	qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface
Date: Thu, 28 Apr 2016 10:42:33 +0200	[thread overview]
Message-ID: <87mvoeruo6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20160428082122.GA4474@noname.redhat.com> (Kevin Wolf's message of "Thu, 28 Apr 2016 10:21:22 +0200")

Kevin Wolf <kwolf@redhat.com> writes:

> Am 27.04.2016 um 17:51 hat Eric Blake geschrieben:
>> On 04/27/2016 03:52 AM, Kevin Wolf wrote:
>> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> > ---
>> >  block/bochs.c | 46 +++++++++++++++++++++++++++++-----------------
>> >  1 file changed, 29 insertions(+), 17 deletions(-)
>> > 
>> 
>> >  static void bochs_close(BlockDriverState *bs)
>> > @@ -267,7 +279,7 @@ static BlockDriver bdrv_bochs = {
>> >      .instance_size	= sizeof(BDRVBochsState),
>> >      .bdrv_probe		= bochs_probe,
>> >      .bdrv_open		= bochs_open,
>> > -    .bdrv_read          = bochs_co_read,
>> > +    .bdrv_co_preadv = bochs_co_preadv,
>> >      .bdrv_close		= bochs_close,
>> >  };
>> 
>> Alignment is funky here.  I'd rather just get rid of all the extra
>> spaces, if that's easier than having half but not all of the = aligned.
>
> Alignment is funky by definition when there are tabs involved and new
> code follows the coding style and uses spaces instead. With a tab stop
> of 4, this is aligned correctly.

Four?  It comes out correctly with tab-width 8 for me.

You can have any tab stops you want as long as it's multiples of eight.

> The other option would be to just convert the whole struct to spaces,
> but that's not really related to this patch and I think we're avoiding
> pure style cleanup patches to keep things like 'git blame' useful.

We normally untabify the lines we touch anyway, and leave the rest
alone.