Re: [EXTERNAL] [PATCH 07/10] crypto: qat - add bank save and restore flows

From: Kamlesh Gurudasani <kamlesh@ti.com>
To: Xin Zeng <xin.zeng@intel.com>, <herbert@gondor.apana.org.au>,
	<alex.williamson@redhat.com>, <jgg@nvidia.com>,
	<yishaih@nvidia.com>, <shameerali.kolothum.thodi@huawei.com>,
	<kevin.tian@intel.com>
Cc: <linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>,
	<qat-linux@intel.com>, Siming Wan <siming.wan@intel.com>,
	Xin Zeng <xin.zeng@intel.com>
Subject: Re: [EXTERNAL] [PATCH 07/10] crypto: qat - add bank save and restore flows
Date: Sun, 4 Feb 2024 13:19:34 +0530	[thread overview]
Message-ID: <87o7cwzn1t.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20240201153337.4033490-8-xin.zeng@intel.com>

Xin Zeng <xin.zeng@intel.com> writes:

> This message was sent from outside of Texas Instruments. 
> Do not click links or open attachments unless you recognize the source of this email and know the content is safe. 
>  
> From: Siming Wan <siming.wan@intel.com>
>
> Add logic to save, restore, quiesce and drain a ring bank for QAT GEN4
> devices.
> This allows to save and restore the state of a Virtual Function (VF) and
> will be used to implement VM live migration.
>
> Signed-off-by: Siming Wan <siming.wan@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Xin Zeng <xin.zeng@intel.com>
> Signed-off-by: Xin Zeng <xin.zeng@intel.com>
...
> +#define CHECK_STAT(op, expect_val, name, args...) \
> +({ \
> +	u32 __expect_val = (expect_val); \
> +	u32 actual_val = op(args); \
> +	if (__expect_val != actual_val) \
> +		pr_err("QAT: Fail to restore %s register. Expected 0x%x, but actual is 0x%x\n", \
> +			name, __expect_val, actual_val); \
> +	(__expect_val == actual_val) ? 0 : -EINVAL; \
I was wondering if this can be done like following, saves repeat comparison.

(__expect_val == actual_val) ? 0 : (pr_err("QAT: Fail to restore %s \
                                          register. Expected 0x%x, \
                                          but actual is 0x%x\n", \
                 			  name, __expect_val, \
                                          actual_val), -EINVAL); \
Regards,
Kamlesh

> +})
...