Re: [PATCH 01/10] ASoC: soc-core: add snd_soc_of_parse_node_prefix()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 01/10] ASoC: soc-core: add snd_soc_of_parse_node_prefix()
Date: Mon, 26 Nov 2018 00:07:22 +0000	[thread overview]
Message-ID: <87o9ac3e2l.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20181123135313.GH2089@sirena.org.uk>

Hi Mark

> > +void snd_soc_of_parse_node_prefix(struct device_node *np,
> >  				   struct snd_soc_codec_conf *codec_conf,
> >  				   struct device_node *of_node,
> >  				   const char *propname);
> > +#define snd_soc_of_parse_audio_prefix(card, conf, node, name) \
> > +	snd_soc_of_parse_node_prefix((card)->dev->of_node,    \
> > +				     (conf), (node), (name))
> 
> This is basically fine but it'd be better to make this a static inline
> rather than a #define - it helps with error messages and type safety.
> I'll apply the series since otherwise this looks good, please send a
> followup patch fixing this.

OK, thanks.
Yes, I will post it soon

Best regards
---
Kuninori Morimoto