From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH 2/3] ASoC: pcm3168a: add hw constraint for channel
Date: Fri, 12 Oct 2018 06:31:18 +0000 [thread overview]
Message-ID: <87o9bzbs4t.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
LEFT_J / I2S only can use TDM.
This patch adds channel constraint for it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/codecs/pcm3168a.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 233a8df5..f0e2b88 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -484,6 +484,7 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream,
bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
unsigned int fmt;
unsigned int sample_min;
+ unsigned int channel_max;
if (tx)
fmt = pcm3168a->dac_fmt;
@@ -496,19 +497,38 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream,
* RIGHT_J : 24 / 16
* LEFT_J : 24
* I2S : 24
+ *
+ * TDM available
+ *
+ * I2S
+ * LEFT_J
*/
switch (fmt) {
case PCM3168A_FMT_RIGHT_J:
sample_min = 16;
+ channel_max = 2;
+ break;
+ case PCM3168A_FMT_LEFT_J:
+ sample_min = 24;
+ channel_max = 8;
+ break;
+ case PCM3168A_FMT_I2S:
+ sample_min = 24;
+ channel_max = 8;
break;
default:
sample_min = 24;
+ channel_max = 2;
}
snd_pcm_hw_constraint_minmax(substream->runtime,
SNDRV_PCM_HW_PARAM_SAMPLE_BITS,
sample_min, 32);
+ snd_pcm_hw_constraint_minmax(substream->runtime,
+ SNDRV_PCM_HW_PARAM_CHANNELS,
+ 2, channel_max);
+
return 0;
}
static const struct snd_soc_dai_ops pcm3168a_dac_dai_ops = {
--
2.7.4
next prev parent reply other threads:[~2018-10-12 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 6:29 [PATCH 0/3] ASoC: pcm3168a: add TDM support Kuninori Morimoto
2018-10-12 6:31 ` [PATCH 1/3] ASoC: pcm3168a: add HW constraint for non RIGHT_J Kuninori Morimoto
2018-10-12 17:00 ` Applied "ASoC: pcm3168a: add HW constraint for non RIGHT_J" to the asoc tree Mark Brown
2018-10-12 6:31 ` Kuninori Morimoto [this message]
2018-10-12 17:00 ` Applied "ASoC: pcm3168a: add hw constraint for channel" " Mark Brown
2018-10-12 6:31 ` [PATCH 3/3] ASoC: pcm3168a: add I2S/Left_J TDM support Kuninori Morimoto
2018-10-12 17:00 ` Applied "ASoC: pcm3168a: add I2S/Left_J TDM support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9bzbs4t.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.