From: Thomas Gleixner <tglx@linutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Mark Brown <broonie@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <maz@kernel.org>, "Z.Q. Hou" <zhiqiang.hou@nxp.com>,
Biwen Li <biwen.li@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regmap: teach regmap to use raw spinlocks if requested in the config
Date: Fri, 27 Aug 2021 21:59:56 +0200 [thread overview]
Message-ID: <87pmty1ww3.ffs@tglx> (raw)
In-Reply-To: <20210827161227.4pnaglgctikobpf6@skbuf>
On Fri, Aug 27 2021 at 16:12, Vladimir Oltean wrote:
> On Fri, Aug 27, 2021 at 01:01:35AM +0200, Thomas Gleixner wrote:
>> Even for the case where the regmap is not dealing with irq chips it does
>> not make any sense to protect low level operations on shared register
>> with a regular spinlock. I might be missing something though...
>
> Mark, any comments?
>
> Generally it is said that misusing raw spinlocks has detrimential
> performance upon the real-time aspects of the system, and I don't really
> have a good feeling for what constitutes misuse vs what is truly justified
> (in fact I did start the thread with "apologies for my novice level of
> understanding").
>
> On the other hand, while it does seem a bit too much overhead for
> sequences of MMIO reads/writes to be able to be preempted, it doesn't
> sound like it would break something either, so...
The question is how long those sequences are.
If it's just a pair or so then the raw spinlock protection has
definitely a smaller worst case than the sleeping spinlock in the
contended case.
OTOH, if regmap operations consist of several dozens of MMIO accesses,
then the preempt disabled region might be quite long.
I'm not familiar enough with regmaps to make a judgement here.
Thanks,
tglx
next prev parent reply other threads:[~2021-08-27 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 20:50 [PATCH 0/2] Use raw spinlocks in the ls-extirq driver Vladimir Oltean
2021-08-25 20:50 ` [PATCH 1/2] regmap: teach regmap to use raw spinlocks if requested in the config Vladimir Oltean
2021-08-26 23:01 ` Thomas Gleixner
2021-08-27 16:12 ` Vladimir Oltean
2021-08-27 19:59 ` Thomas Gleixner [this message]
2021-08-30 10:49 ` Vladimir Oltean
2021-08-30 11:02 ` Rasmus Villemoes
2021-08-30 12:42 ` Mark Brown
2021-08-30 12:19 ` Mark Brown
2021-08-30 14:16 ` Thomas Gleixner
2021-09-01 16:05 ` Mark Brown
2021-09-02 8:35 ` Thomas Gleixner
2021-08-25 20:50 ` [PATCH 2/2] mfd: syscon: request a regmap with raw spinlocks for some devices Vladimir Oltean
2021-08-25 21:24 ` Arnd Bergmann
2021-08-25 22:00 ` Vladimir Oltean
2021-08-26 9:24 ` Arnd Bergmann
2021-08-26 13:57 ` Vladimir Oltean
2021-08-26 14:48 ` Arnd Bergmann
2021-09-06 9:18 ` Lee Jones
2021-08-26 12:51 ` (subset) [PATCH 0/2] Use raw spinlocks in the ls-extirq driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmty1ww3.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=biwen.li@nxp.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.