From: Kalle Valo <kvalo@codeaurora.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
Date: Wed, 24 Feb 2021 18:43:59 +0200 [thread overview]
Message-ID: <87pn0pfmb4.fsf@codeaurora.org> (raw)
In-Reply-To: <20210224163706.519658-1-marcus.folkesson@gmail.com> (Marcus Folkesson's message of "Wed, 24 Feb 2021 17:37:06 +0100")
Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> Write the value instead of reading it twice.
>
> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> index 351ff909ab1c..e14b9fc2c67a 100644
> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
> for (i = 0; (i < 3) && (nint > 0); i++, nint--)
> reg |= BIT(i);
>
> - ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®);
> + ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
To me it looks like the bug existed before commit 5e63a598441a:
- ret = sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®);
+ ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®);
https://git.kernel.org/linus/5e63a598441a
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-02-24 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:37 [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register Marcus Folkesson
2021-02-24 16:43 ` Kalle Valo [this message]
2021-02-25 5:06 ` Ajay.Kathat
2021-02-25 7:09 ` Kalle Valo
2021-02-25 7:35 ` Ajay.Kathat
2021-02-25 8:02 ` Marcus Folkesson
2021-03-15 8:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn0pfmb4.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.