From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Jocelyn Falempe <jfalempe@redhat.com>,
dri-devel@lists.freedesktop.org, airlied@redhat.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
daniel@ffwll.ch, bluescreen_avenger@verizon.net
Subject: Re: [RFC][PATCH 0/2] drm/panic: Add a drm panic handler
Date: Wed, 06 Sep 2023 11:29:18 +0200 [thread overview]
Message-ID: <87r0nb4pld.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <25bd597f-f4b5-8592-f111-898b4a613941@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
Hello Jocelyn and Thomas,
> Hi Jocelyn
>
> Am 05.09.23 um 16:46 schrieb Jocelyn Falempe:
[...]
>>
>> I'm a bit reluctant to re-use the fbdev code, for a few reasons:
>> * I want drm_panic to work if CONFIG_FB and CONFIG_DRM_FBDEV_EMULATION
>> are not set.
>
> The code would live in video/ and be independend from fbdev. It's quite
> a bit of refactoring, but might be worth it in the long term.
>
FWIW, I agree with Thomas here. The drawing/blitting logic seems to be
useful regardless of fbdev and moving it to video/ makes sense to me,
instead of adding yet another infrastructure to do the same that will
only be used for the DRM panic handler.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
prev parent reply other threads:[~2023-09-06 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 19:17 [RFC][PATCH 0/2] drm/panic: Add a drm panic handler Jocelyn Falempe
2023-08-09 19:17 ` [PATCH 1/2] " Jocelyn Falempe
2023-08-10 5:16 ` kernel test robot
2023-08-10 5:16 ` kernel test robot
2023-08-10 6:24 ` kernel test robot
2023-08-10 6:24 ` kernel test robot
2023-08-09 19:17 ` [PATCH 2/2] drm/simpledrm: Add drm_panic support Jocelyn Falempe
2023-08-13 2:20 ` [RFC][PATCH 0/2] drm/panic: Add a drm panic handler nerdopolis
2023-08-21 13:34 ` Jocelyn Falempe
2023-08-22 22:29 ` nerdopolis
2023-09-04 14:29 ` Thomas Zimmermann
2023-09-05 14:46 ` Jocelyn Falempe
2023-09-06 9:14 ` Thomas Zimmermann
2023-09-06 9:29 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0nb4pld.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@redhat.com \
--cc=bluescreen_avenger@verizon.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.