From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/7] ASoC: add soc-link.c
Date: 19 May 2020 13:20:52 +0900 [thread overview]
Message-ID: <87r1vg4kt7.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <afb8d24d294a1c03541e279b95d2c7d740fe3c91.camel@linux.intel.com>
Hi Ranjani
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Current ALSA SoC has many dai_link->xxx() functions.
> > But, it is implemented randomly at random place.
> >
> > This patch creates new soc-link.c to collect dai_link related
> > operation into it.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> > #include <sound/soc-component.h>
> > +#include <sound/soc-link.h>
> Why do we need to include this in soc.h? Is it to ensure that soc-
> link.h included in all files that include soc.h?
>
> I think the right way to do this would be include soc-link.h where it
> is needed, say for example in soc-pcm.c etc.
OK.
Will check and update it in v2
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2020-05-19 4:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 0:59 [PATCH 0/7] ASoC: add soc-link Kuninori Morimoto
2020-05-19 1:01 ` [PATCH 1/7] ASoC: add soc-link.c Kuninori Morimoto
2020-05-19 1:42 ` Ranjani Sridharan
2020-05-19 4:20 ` Kuninori Morimoto [this message]
2020-05-19 1:01 ` [PATCH 2/7] ASoC: soc-link: move soc_rtd_xxx() Kuninori Morimoto
2020-05-19 1:01 ` [PATCH 3/7] ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx() Kuninori Morimoto
2020-05-19 1:02 ` [PATCH 4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup() Kuninori Morimoto
2020-05-19 1:45 ` Ranjani Sridharan
2020-05-19 4:16 ` Kuninori Morimoto
2020-05-19 1:02 ` [PATCH 5/7] ASoC: soc-link: add snd_soc_link_compr_startup() Kuninori Morimoto
2020-05-19 1:47 ` Ranjani Sridharan
2020-05-19 4:18 ` Kuninori Morimoto
2020-05-19 1:02 ` [PATCH 6/7] ASoC: soc-link: add snd_soc_link_compr_shutdown() Kuninori Morimoto
2020-05-19 1:02 ` [PATCH 7/7] ASoC: soc-link: add snd_soc_link_compr_set_params() Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1vg4kt7.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.