Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

From: Eric Anholt <eric@anholt.net>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Revert syncobj timeline changes.
Date: Thu, 15 Nov 2018 10:47:36 -0800	[thread overview]
Message-ID: <87r2fmyy7r.fsf@anholt.net> (raw)
In-Reply-To: <87bm6rb0cy.fsf@anholt.net>

[-- Attachment #1.1: Type: text/plain, Size: 3176 bytes --]

Eric Anholt <eric@anholt.net> writes:

> [ Unknown signature status ]
> "Koenig, Christian" <Christian.Koenig@amd.com> writes:
>
>> Hi Eric,
>>
>> thanks for your time to test this.
>>
>> Am 14.11.18 um 08:07 schrieb Eric Anholt:
>>> zhoucm1 <zhoucm1@amd.com> writes:
>>>
>>>> Ping.. Eric, Could you help try attached patch for your memory issue?
>>>>
>>>> If you have no time, Could you tell me which tests you're using? Where
>>>> can I get the test app?
>>> You sent the patch yesterday.  I burned 3 of the 4 days I worked last
>>> week trying to track down this pile of regressions, and I had other
>>> things I was supposed to be doing.  My driver is *still* broken in
>>> drm-misc-next.
>>
>> Including the revert?
>
> As far as I know?  Today I worked on cleaning up my old igts so I'll
> have automated tests of v3d gpu reset instead of a git stash of some
> mesa hacks.  Once that's ready I'll rebase onto drm-misc-next and try
> again, hopefully tomorrow.

OK, got the igts working.  My test is:

Submit hanging job
Submit non-hanging job
Wait on non-hanging job.

With patch 1/2 in place, recovery works -- the wait returns after 2
seconds.  With patch 1/2 removed, the test never completes, and a ^C
produces:

[   96.795892] ------------[ cut here ]------------
[   96.795932] WARNING: CPU: 3 PID: 3149 at drivers/dma-buf/dma-fence.c:225 dma_fence_release+0xfc/0x1b0
[   96.795937] Modules linked in:
[   96.795948] CPU: 3 PID: 3149 Comm: v3d_cl_hang Not tainted 4.20.0-rc1+ #497
[   96.795953] Hardware name: Broadcom STB (Flattened Device Tree)
[   96.795971] [<c021237c>] (unwind_backtrace) from [<c020d8f0>] (show_stack+0x10/0x14)
[   96.795984] [<c020d8f0>] (show_stack) from [<c0c3f6a8>] (dump_stack+0xa8/0xd4)
[   96.795997] [<c0c3f6a8>] (dump_stack) from [<c0223568>] (__warn.part.3+0xbc/0xec)
[   96.796005] [<c0223568>] (__warn.part.3) from [<c02236f8>] (warn_slowpath_null+0x44/0x4c)
[   96.796012] [<c02236f8>] (warn_slowpath_null) from [<c0874b04>] (dma_fence_release+0xfc/0x1b0)
[   96.796024] [<c0874b04>] (dma_fence_release) from [<c06f08fc>] (drm_sched_fence_release_scheduled+0x64/0x68)
[   96.796032] [<c06f08fc>] (drm_sched_fence_release_scheduled) from [<c06f0f84>] (drm_sched_entity_fini+0x1e4/0x1e8)
[   96.796042] [<c06f0f84>] (drm_sched_entity_fini) from [<c083c9cc>] (v3d_postclose+0x18/0x2c)
[   96.796055] [<c083c9cc>] (v3d_postclose) from [<c06be7b8>] (drm_file_free.part.0+0x1e8/0x2c0)
[   96.796064] [<c06be7b8>] (drm_file_free.part.0) from [<c06bedf0>] (drm_release+0x8c/0x108)
[   96.796074] [<c06bedf0>] (drm_release) from [<c03930ec>] (__fput+0xa4/0x1e4)
[   96.796083] [<c03930ec>] (__fput) from [<c02480cc>] (task_work_run+0x9c/0xd0)
[   96.796092] [<c02480cc>] (task_work_run) from [<c022817c>] (do_exit+0x474/0xbf0)
[   96.796099] [<c022817c>] (do_exit) from [<c0229de0>] (do_group_exit+0x3c/0xbc)
[   96.796111] [<c0229de0>] (do_group_exit) from [<c02371a4>] (get_signal+0x250/0x9f4)
[   96.796118] [<c02371a4>] (get_signal) from [<c020cf00>] (do_work_pending+0x118/0x5f8)
[   96.796126] [<c020cf00>] (do_work_pending) from [<c0201034>] (slow_work_pending+0xc/0x20)
[   96.796131] Exception stack(0xe90f7fb0 to 0xe90f7ff8)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel