Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Init DDI outputs based on port_mask on skl+

From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Init DDI outputs based on port_mask on skl+
Date: Fri, 09 Jun 2023 12:19:26 +0300	[thread overview]
Message-ID: <87sfb1q9gh.fsf@intel.com> (raw)
In-Reply-To: <ZIIwlpYuGQAYQNYK@intel.com>

On Thu, 08 Jun 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Jun 02, 2023 at 05:41:50PM +0300, Jani Nikula wrote:
>> This reflects current code, but apparently commit e341c618acde
>> ("drm/i915/adl_s: Initialize display for ADL-S") stopped initializing
>> DSI for ADL-S. It does support DSI.
>
> Not according to bspec. The diagram does still show the
> DSI transcoders being present but the PHY is missing.

My bad. R-b holds.

>
>> 
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> 
>> > +
>> > +		if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv))
>> > +			vlv_dsi_init(dev_priv);
>> >  	} else if (HAS_DDI(dev_priv)) {
>> >  		u32 found;
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center