From: Vladimir Nikishkin <vladimir@nikishkin.pw>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com,
razor@blackwall.org, idosch@nvidia.com, liuhangbin@gmail.com,
eyal.birger@gmail.com, jtoppins@redhat.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v7 2/2] Add tests for vxlan nolocalbypass option.
Date: Fri, 05 May 2023 09:33:03 +0800 [thread overview]
Message-ID: <87sfcb8sej.fsf@laptop.lockywolf.net> (raw)
In-Reply-To: <ZFPWNXtV7sTmH/aQ@shredder>
Ido Schimmel <idosch@idosch.org> writes:
> On Tue, May 02, 2023 at 12:25:30AM +0800, Vladimir Nikishkin wrote:
>> Add test to make sure that the localbypass option is on by default.
>>
>> Add test to change vxlan localbypass to nolocalbypass and check
>> that packets are delivered to userspace.
>
> What do you think about this version [1]?
I think that your idea of making "nolocalbypass" applicable universally
is more clear and more straightforward than doing an exception to a
special case, as the original patch does. I had actually considered such
a change myself, and only decided against it because I wanted a patch
that changes the existing behaviour in a minimal way.
If you are happy with a more radical behaviour for "nolocalbypass", I am
all for it.
I can even imagine a line in the documentation, something along the
lines of "The use of the nolocalbypass flag makes debugging easier,
because the packets are seen on widely available userspace network
debugging tools, such as tcpdump. You might want to debug and tweak your
system using this flag, and when you are convinced that the system is
working as expected, turn it off for a performance gain."
I will re-submit this series of patches on after the 8th of May 2023.
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
--
Fastmail.
next prev parent reply other threads:[~2023-05-05 1:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 16:25 [PATCH net-next v7 1/2] Add nolocalbypass option to vxlan Vladimir Nikishkin
2023-05-01 16:25 ` [PATCH net-next v7 2/2] Add tests for vxlan nolocalbypass option Vladimir Nikishkin
2023-05-02 10:14 ` Paolo Abeni
2023-05-04 15:58 ` Ido Schimmel
2023-05-05 1:33 ` Vladimir Nikishkin [this message]
2023-05-05 8:52 ` Ido Schimmel
2023-05-01 17:12 ` [PATCH net-next v7 1/2] Add nolocalbypass option to vxlan Stephen Hemminger
2023-05-02 5:50 ` Vladimir Nikishkin
2023-05-04 13:05 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfcb8sej.fsf@laptop.lockywolf.net \
--to=vladimir@nikishkin.pw \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=gnault@redhat.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.