From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value
Date: Tue, 20 Apr 2021 13:24:24 +0200 [thread overview]
Message-ID: <87sg3l2o7r.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <d52db89bc2f40a9df5e9fafe4e1bb8c173a7f45f.1618847606.git.ps@pks.im>
On Mon, Apr 19 2021, Patrick Steinhardt wrote:
> +test_expect_success 'git --config-env with missing value' '
> + test_must_fail env ENVVAR=value git --config-env 2>error &&
> + test_i18ngrep "no config key given for --config-env" error &&
> + test_must_fail env ENVVAR=value git --config-env config core.name 2>error &&
> + test_i18ngrep "invalid config format: config" error
> +'
> +
Nit: (not spotted on the first reading): s/test_i18ngrep/grep/.
> test_expect_success 'git --config-env fails with invalid parameters' '
> test_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&
> test_i18ngrep "invalid config format: foo.flag" error &&
next prev parent reply other threads:[~2021-04-20 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 15:56 [PATCH 0/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-19 15:56 ` [PATCH 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-19 15:56 ` [PATCH 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-20 10:52 ` Ævar Arnfjörð Bjarmason
2021-04-23 10:07 ` Jeff King
2021-04-20 11:24 ` Ævar Arnfjörð Bjarmason [this message]
2021-04-29 12:55 ` [PATCH v2 0/2] " Patrick Steinhardt
2021-04-29 12:55 ` [PATCH v2 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-29 12:55 ` [PATCH v2 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-29 20:04 ` [PATCH v2 0/2] " Jeff King
2021-04-30 0:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg3l2o7r.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.