From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Wen Yang <wenyang@linux.alibaba.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
stable@vger.kernel.org, alexander.shishkin@linux.intel.com
Subject: Re: [GIT PULL 1/3] intel_th: Fix a double put_device() in error path
Date: Wed, 20 Nov 2019 15:44:34 +0200 [thread overview]
Message-ID: <87sgmid5ml.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <2e648871-b7f7-c77e-6a22-3c26ad90633b@linux.alibaba.com>
Wen Yang <wenyang@linux.alibaba.com> writes:
> device_add() has increased the reference count,
>
> so when it returns an error, an additional call to put_device()
>
> is needed here to reduce the reference count.
No, in case of error it also drops its reference.
Regards,
--
Alex
next prev parent reply other threads:[~2019-11-20 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 13:08 [GIT PULL 0/3] intel_th: Updates for v5.5 Alexander Shishkin
2019-11-20 13:08 ` [GIT PULL 1/3] intel_th: Fix a double put_device() in error path Alexander Shishkin
2019-11-20 13:36 ` Wen Yang
2019-11-20 13:44 ` Alexander Shishkin [this message]
2019-11-20 13:08 ` [GIT PULL 2/3] intel_th: pci: Add Ice Lake CPU support Alexander Shishkin
2019-11-20 13:08 ` [GIT PULL 3/3] intel_th: pci: Add Tiger " Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgmid5ml.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.