From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
armbru@redhat.com, philmd@linaro.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: Re: [PATCH] qemu-nbd: changes towards enabling -Wshadow=local
Date: Fri, 29 Sep 2023 08:50:42 +0200 [thread overview]
Message-ID: <87ttrdh3r1.fsf@pond.sub.org> (raw)
In-Reply-To: <20230922205019.2755352-2-eblake@redhat.com> (Eric Blake's message of "Fri, 22 Sep 2023 15:50:20 -0500")
Eric Blake <eblake@redhat.com> writes:
> Address all compiler complaints from -Wshadow in qemu-nbd. Several
> instances of 'int ret' became shadows when commit 4fbec260 added 'ret'
> at a higher scope in main. More interesting was the 'void *ret'
> capturing the result of a pthread; where we were conceptually doing
> '(void*)(intptr_t)EXIT_FAILURE != NULL' which just feels wrong (even
> though it happens to compile correctly), so it was worth a better
> cleanup.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> I'm happy to let Markus collect this with the growing pile on
> shadow-next, instead of going through my NBD tree.
Queued, thanks!
prev parent reply other threads:[~2023-09-29 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 20:50 [PATCH] qemu-nbd: changes towards enabling -Wshadow=local Eric Blake
2023-09-25 8:53 ` Daniel P. Berrangé
2023-09-29 6:50 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttrdh3r1.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.