Re: [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"

From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
Date: Fri, 05 May 2023 12:44:50 +0200	[thread overview]
Message-ID: <87v8h7hxb1.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZFTOpRduzMVakOGx@ugly>

On Fri, 05 May 2023 11:38:45 +0200,
Oswald Buddenhagen wrote:
> 
> On Fri, May 05, 2023 at 11:31:16AM +0200, Takashi Iwai wrote:
> > On Fri, 05 May 2023 09:38:09 +0200,
> > Jaroslav Kysela wrote:
> >> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
> > 
> > Better to add Reported-by and the reference for the original thread
> > reporting the regression,
> > 
> i'll post a slight rework of the series shortly, where i'll include
> this.
> 
> > as well as the Fixes tag.
> > 
> that seems pointless for a revert, as all the info is already included
> anyway, no?

People tend to look at Fixes tag to judge whether the commit can fix
something real or not.  For example, we (at SUSE) regularly check
Fixes tag to pick up the missing fixing.
In the case of a revert, it doesn't mean always a fix.  So it's not
mandatory, but would be still helpful.

thanks,

Takashi