Re: [PATCH] scripts/qapi: minor delinting

From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Michael Roth <michael.roth@amd.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] scripts/qapi: minor delinting
Date: Mon, 14 Feb 2022 14:48:45 +0100	[thread overview]
Message-ID: <87v8xhimo2.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFn=p-ZVqhGF=6SEYtD4F=p0iyyWK+6oNvc_w-7ctkmEmpOP9w@mail.gmail.com> (John Snow's message of "Fri, 11 Feb 2022 13:36:02 -0500")

John Snow <jsnow@redhat.com> writes:

> On Fri, Feb 11, 2022 at 12:11 PM John Snow <jsnow@redhat.com> wrote:
>>
>> On Fri, Feb 11, 2022 at 6:58 AM Markus Armbruster <armbru@redhat.com> wrote:

[...]

>> > Several of the names in scripts/qapi/pylintrc's good-names don't
>> > actually occur in the code.
>> >
>> > Could I persuade you to replace it with something like
>> >
>> >     good-names-rgxs=^[_a-z][_a-z0-9]?$
>> >
>> > and call it a day?
>> >
>>
>> I've been growing that good-names list out from python/, so they
>> probably appear over in there somewhere.

I see.

>>                                          And uh, eh. In the interest
>> of just moving on to something more interesting, sure. (I reserve the
>> right to change my mind when I attempt to get the CI system protecting
>> the type safety of qapi-gen, when we'll need a single configuration
>> for everything. We can fight about it then.)

Okay.

> (Oh, and some of the names are the default allow list, actually.
> Setting the variable overwrites the default configuration instead of
> amending it, so that's where some of those come from, too. My goal is
> generally to stick to as close to the default configuration as I can
> bear, in the hopes of preventing the fostering of a coding style that
> is too specialized to just qemu.git.)

I agree we shouldn't invent a Python coding style.  I just wish pylint
didn't, either ;-P