From: Michael Ellerman <mpe@ellerman.id.au>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jannh@google.com, linux-mm@kvack.org, khalid.aziz@oracle.com,
aarcange@redhat.com, fweimer@redhat.com, jhubbard@nvidia.com,
willy@infradead.org, abdhalee@linux.vnet.ibm.com, joel@jms.id.au,
keescook@chromium.org, jasone@google.com,
davidtgoldblatt@gmail.com, trasz@freebsd.org,
danielmicay@gmail.com
Subject: Re: [PATCH] selftests/vm: Add a test for MAP_FIXED_NOREPLACE
Date: Tue, 16 Oct 2018 11:15:04 +1100 [thread overview]
Message-ID: <87va62lpbr.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181015080724.GC18839@dhcp22.suse.cz>
Michal Hocko <mhocko@kernel.org> writes:
> On Sun 14-10-18 00:39:29, Michael Ellerman wrote:
>> Add a test for MAP_FIXED_NOREPLACE, based on some code originally by
>> Jann Horn. This would have caught the overlap bug reported by Daniel Micay.
>>
>> I originally suggested to Michal that we create MAP_FIXED_NOREPLACE, but
>> instead of writing a selftest I spent my time bike-shedding whether it
>> should be called MAP_FIXED_SAFE/NOCLOBBER/WEAK/NEW .. mea culpa.
>
> You wer one of those to provide a useful feedback actually. So no reason
> to feel sorry. I should have been forced to write a test case instead.
> No idea why I haven't considered that myself actually. So I steal your
> culpa here.
Haha, plenty of culpa to go around :)
Yeah we should try to always have selftests for new flags and things
like this.
This one was a bit special because the original point of the new flag
was for the kernel to use internally, and we sort of forgot that we were
also adding a user-visible flag.
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Thanks for doing this!
> Acked-by: Michal Hocko <mhocko@suse.com>
Thanks.
cheers
prev parent reply other threads:[~2018-10-16 0:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 13:39 [PATCH] selftests/vm: Add a test for MAP_FIXED_NOREPLACE Michael Ellerman
2018-10-14 1:16 ` Kees Cook
2018-10-15 7:39 ` Khalid Aziz
2018-10-15 8:07 ` Michal Hocko
2018-10-16 0:15 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va62lpbr.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aarcange@redhat.com \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=danielmicay@gmail.com \
--cc=davidtgoldblatt@gmail.com \
--cc=fweimer@redhat.com \
--cc=jannh@google.com \
--cc=jasone@google.com \
--cc=jhubbard@nvidia.com \
--cc=joel@jms.id.au \
--cc=keescook@chromium.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=trasz@freebsd.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.