From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Haren Myneni <haren@linux.vnet.ibm.com>,
herbert@gondor.apana.org.au, mpe@ellerman.id.au,
ddstreet@ieee.org
Cc: mikey@neuling.org, suka@us.ibm.com, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/5] crypto/nx: Add P9 NX support for 842 compression engine.
Date: Mon, 03 Apr 2017 11:37:22 +1000 [thread overview]
Message-ID: <87vaqmmfu5.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1491066107.29552.29.camel@hbabu-laptop>
Haren Myneni <haren@linux.vnet.ibm.com> writes:
> @@ -656,13 +953,21 @@ static __init int nx842_powernv_init(void)
> BUILD_BUG_ON(DDE_BUFFER_ALIGN % DDE_BUFFER_SIZE_MULT);
> BUILD_BUG_ON(DDE_BUFFER_SIZE_MULT % DDE_BUFFER_LAST_MULT);
>
> - for_each_compatible_node(dn, NULL, "ibm,power-nx")
> - nx842_powernv_probe(dn);
> + if (is_vas_available()) {
> + for_each_compatible_node(dn, NULL, "ibm,xscom")
> + nx842_powernv_probe_vas(dn);
I'm not keen on how the device bindings work, instead, I think firmware
should provide a 'ibm,vas' compatible node, rather than simply searching
through all the ibm,xscom nodes.
XSCOMs aren't something that Linux should really know about, it's a
debug interface, and one we use through PRD to do PRD-things, XSCOMs
aren't part of the architecture.
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2017-04-03 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 17:01 [PATCH 4/5] crypto/nx: Add P9 NX support for 842 compression engine Haren Myneni
2017-04-03 1:37 ` Stewart Smith [this message]
2017-04-04 10:55 ` Michael Ellerman
2017-04-05 21:49 ` Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaqmmfu5.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=ddstreet@ieee.org \
--cc=haren@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=suka@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.