From: Fabiano Rosas <farosas@suse.de>
To: Li Zhijian <lizhijian@fujitsu.com>,
quintela@redhat.com, peterx@redhat.com, leobras@redhat.com
Cc: qemu-devel@nongnu.org, Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [PATCH 1/2] migration: Fix rdma migration failed
Date: Wed, 20 Sep 2023 09:46:14 -0300 [thread overview]
Message-ID: <87wmwlm2qx.fsf@suse.de> (raw)
In-Reply-To: <20230920090412.726725-1-lizhijian@fujitsu.com>
Li Zhijian <lizhijian@fujitsu.com> writes:
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
>
> Destination will fail with:
> qemu-system-x86_64: rdma: Too many requests in this message (3638950032).Bailing.
>
> migrate with RDMA is different from tcp. RDMA has its own control
> message, and all traffic between RDMA_CONTROL_REGISTER_REQUEST and
> RDMA_CONTROL_REGISTER_FINISHED should not be disturbed.
Yeah, this is really fragile. We need a long term solution to this. Any
other change to multifd protocol as well as any other change to the
migration ram handling might hit this issue again.
Perhaps commit 294e5a4034 ("multifd: Only flush once each full round of
memory") should simply not have touched the stream at that point, but we
don't have any explicit safeguards to avoid interleaving flags from
different layers like that (assuming multifd is at another logical layer
than the ram handling).
I don't have any good suggestions at this moment, so for now:
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2023-09-20 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 9:04 [PATCH 1/2] migration: Fix rdma migration failed Li Zhijian
2023-09-20 9:04 ` [PATCH 2/2] migration/rdma: zore out head.repeat to make the error more clear Li Zhijian
2023-09-20 13:01 ` Fabiano Rosas
2023-09-21 1:36 ` Zhijian Li (Fujitsu)
2023-09-21 12:29 ` Fabiano Rosas
2023-09-22 15:44 ` Peter Xu
2023-09-20 12:46 ` Fabiano Rosas [this message]
2023-09-22 7:42 ` [PATCH 1/2] migration: Fix rdma migration failed Zhijian Li (Fujitsu)
2023-09-21 1:40 ` Zhijian Li (Fujitsu)
2023-09-22 15:42 ` Peter Xu
2023-09-22 15:59 ` Fabiano Rosas
2023-09-22 16:09 ` Peter Xu
2023-09-25 8:59 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmwlm2qx.fsf@suse.de \
--to=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lizhijian@fujitsu.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.