Re: [PATCH -v5 0/9] migrate_pages(): batch TLB flushing

From: "Huang, Ying" <ying.huang@intel.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jan Kara <jack@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Zi Yan <ziy@nvidia.com>,
	Yang Shi <shy828301@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Oscar Salvador <osalvador@suse.de>,
	Matthew Wilcox <willy@infradead.org>,
	Bharata B Rao <bharata@amd.com>,
	Alistair Popple <apopple@nvidia.com>,
	Xin Hao <xhao@linux.alibaba.com>,
	Minchan Kim <minchan@kernel.org>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	"Xu, Pengfei" <pengfei.xu@intel.com>,
	Christoph Hellwig <hch@lst.de>, Stefan Roesch <shr@devkernel.io>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH -v5 0/9] migrate_pages(): batch TLB flushing
Date: Wed, 22 Feb 2023 09:02:41 +0800	[thread overview]
Message-ID: <87wn4acy1a.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20f1628e-96a7-3a5d-fef5-dae31f8eb196@google.com> (Hugh Dickins's message of "Tue, 21 Feb 2023 14:25:41 -0800 (PST)")

Hugh Dickins <hughd@google.com> writes:

> On Tue, 21 Feb 2023, Huang, Ying wrote:
>> 
>> On second thought, I think that it may be better to provide a fix as
>> simple as possible firstly.  Then we can work on a more complex fix as
>> we discussed above.  The simple fix is easy to review now.  And, we will
>> have more time to test and review the complex fix.
>> 
>> In the following fix, I disabled the migration batching except for the
>> MIGRATE_ASYNC mode, or the split folios of a THP folio.  After that, I
>> will work on the complex fix to enable migration batching for all modes.
>> 
>> What do you think about that?
>
> I don't think there's a need to rush in the wrong fix so quickly.
> Your series was in (though sometimes out of) linux-next for some
> while, without causing any widespread problems.  Andrew did send
> it to Linus yesterday, I expect he'll be pushing it out later today
> or tomorrow, but I don't think it's going to cause big problems.
> Aiming for a fix in -rc2 would be good.

Sure, I will target to fix in -rc2.  Thanks for suggestion!

> Why would it be complex?

Now, I think the big picture could be,

if (MIGRATE_ASYNC) {
        migrate_pages_batch(from,);
} else {
        migrate_pages_batch(from,, MIGRATE_ASYNC,);
        list_for_each_entry_safe (folio,, from) {
                migrate_pages_batch(one_folio, , MIGRATE_SYNC,);
        }
}

That is, for synchronous migration, try asynchronous batched migration
firstly, then fall back to synchronous migration one by one.  This will
make the retry logic easier to be understood.

This needs some code change.  Anyway, I will try to do that and show the
code.

Best Regards,
Huang, Ying