From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: "Michel Dänzer" <michel@daenzer.net>,
intel-gfx@lists.freedesktop.org,
"Keith Packard" <keithp@keithp.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.
Date: Thu, 15 Feb 2018 11:55:07 -0800 [thread overview]
Message-ID: <87wozem3j8.fsf@rdvivi-vienna.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CAPM=9twjeq-JJF=Fg_54m77amkX1fmZ7_csjWxrd96ZHvUrkRg@mail.gmail.com>
Dave Airlie <airlied@gmail.com> writes:
> On 6 February 2018 at 06:32, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> On Sat, Feb 03, 2018 at 08:14:48AM +0000, Keith Packard wrote:
>>> Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> writes:
>>>
>>> > From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
>>> >
>>> > drm_vblank_count() has an u32 type returning what is a 64-bit vblank count.
>>> > The effect of this is when drm_wait_vblank_ioctl() tries to widen the user
>>> > space requested vblank sequence using this clipped 32-bit count(when the
>>> > value is >= 2^32) as reference, the requested sequence remains a 32-bit
>>> > value and gets queued like that. However, the code that checks if the
>>> > requested sequence has passed compares this against the 64-bit vblank
>>> > count.
>>>
>>> For patches 1-7:
>>>
>>> Reviewed-by: Keith Packard <keithp@keithp.com>
>>
>> Dave, ack to merge them through drm-intel-next-queued ?
>
> Ack. do we know if any of those need to be in -fixes?
All patches merged to drm-intel-next-queued.
Thanks for the patches, reviews and acks.
>
> or too early to tell?
>
> Dave.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-15 19:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 5:12 [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 02/10] drm/i915/vblank: Make the vblank counter u64 -> u32 typecast explicit Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 03/10] drm/i915: Handle 64-bit return from drm_crtc_vblank_count() Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 04/10] drm/amdgpu: " Dhinakaran Pandiyan
2018-02-05 15:20 ` Harry Wentland
2018-02-05 18:11 ` Alex Deucher
2018-02-03 5:12 ` [PATCH 05/10] drm/radeon: " Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 06/10] drm/tegra: " Dhinakaran Pandiyan
2018-02-07 1:41 ` Pandiyan, Dhinakaran
2018-02-07 9:41 ` Thierry Reding
2018-02-07 21:32 ` Pandiyan, Dhinakaran
2018-02-13 7:55 ` Rodrigo Vivi
2018-02-14 18:41 ` [Intel-gfx] " Rodrigo Vivi
2018-02-15 12:17 ` Thierry Reding
2018-02-03 5:12 ` [PATCH 07/10] drm/atomic: " Dhinakaran Pandiyan
2018-02-03 5:13 ` [PATCH 08/10] drm/vblank: Do not update vblank count if interrupts are already disabled Dhinakaran Pandiyan
2018-02-03 5:13 ` [PATCH 09/10] drm/vblank: Restoring vblank counts after device PM events Dhinakaran Pandiyan
2018-02-19 22:39 ` Daniel Vetter
2018-02-03 5:13 ` [PATCH 10/10] drm/i915: Estimate and update missed vblanks Dhinakaran Pandiyan
2018-02-03 6:16 ` ✓ Fi.CI.BAT: success for series starting with [01/10] drm/vblank: Data type fixes for 64-bit vblank sequences Patchwork
2018-02-03 8:14 ` [PATCH 01/10] " Keith Packard
2018-02-05 20:32 ` Rodrigo Vivi
2018-02-05 20:37 ` Dave Airlie
2018-02-05 20:49 ` Rodrigo Vivi
2018-02-05 21:11 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-02-05 23:41 ` Keith Packard
2018-02-15 19:55 ` Rodrigo Vivi [this message]
2018-02-16 18:49 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-02-03 9:58 ` ✗ Fi.CI.IGT: failure for series starting with [01/10] " Patchwork
2018-02-06 18:38 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-07 7:20 ` ✗ Fi.CI.BAT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wozem3j8.fsf@rdvivi-vienna.i-did-not-set--mail-host-address--so-tickle-me \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.