From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, patchwork-lst@pengutronix.de,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH] Revert "ASoC: simple-card-utils: enable "label" on asoc_simple_card_parse_card_name"
Date: Tue, 29 Aug 2017 23:57:30 +0000 [thread overview]
Message-ID: <87wp5morwb.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87y3q2os2m.wl%kuninori.morimoto.gx@renesas.com>
Hi Lucas, again
> > This commit breaks existing systems, as snd_soc_of_parse_card_name() doesn't
> > return an error if the DT name property is missing, which would be required
> > to hit the fallback path in the offending commit at all.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > This should be fixed properly, but given the timing with the 4.13 release
> > being really close, I opted for just reverting the offending commit.
>
> Sorry, but I don't understand your issue, and why it happens.
> It tries to find "label" -> "[prefix]name" -> error.
> The difference from previous version (tries "[prefix]name" -> error)
> is just checking "label".
> Do you know why it doesn't return error ?
I missed your fixup patch.
Sorry for my noise
Best regards
---
Kuninori Morimoto
prev parent reply other threads:[~2017-08-29 23:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:36 [PATCH] Revert "ASoC: simple-card-utils: enable "label" on asoc_simple_card_parse_card_name" Lucas Stach
2017-08-29 23:53 ` Kuninori Morimoto
2017-08-29 23:57 ` Kuninori Morimoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp5morwb.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=patchwork-lst@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.