Re: More Generic Audio Graph Sound Card idea

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: sharadg@nvidia.com, Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	jonathanh@nvidia.com
Subject: Re: More Generic Audio Graph Sound Card idea
Date: 27 Aug 2020 10:36:54 +0900	[thread overview]
Message-ID: <87y2m0vplk.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <f21353ca-5d47-afac-3451-f951eced36e2@nvidia.com>

Hi Sameer

> >          static audio_graph_hooks hooks = {
> >                  .parse_of_hook_pre  = xxx,
> > =>              .parse_of_hook_post = sameer_parse_of_post,
> 
> We may end up re-parsing the whole stuff under 'hook_post' (which
> appears redundant) because I am forcing DPCM and would like
> func_dpcm() to execute for all links. If I could set a flag under
> 'hooks' and if 'audio-graph-card' can use it to force DPCM, it would
> appear to be a better choice.

Asking how to judge link to driver is maybe nice idea.

I didn't mentioned in order not to not diverge,
but I'm also thinking that some overwrite function itself
as you mentioned.

	if (priv->hooks->func_pre)
		priv->hooks->func_pre(...);

	if (priv->hooks->func)
		priv->hooks->func(...);	/* driver's function */
	else
		graph_func(...);	/* audio-graph function */

	if (priv->hooks->func_post)
		priv->hooks->func_post(...);

Thank you for your help !!

Best regards
---
Kuninori Morimoto