From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Bhumika Goyal <bhumirks@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] ASoC: uda1380: fix regression by adding back .read/.write
Date: Tue, 16 Jan 2018 01:59:53 +0000 [thread overview]
Message-ID: <87y3ky8sz2.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <871siqa7mk.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
commit c001bf633a9 ("ASoC: use internal reg_cache on uda1380")
removed .read/.write from driver, but it might breaks non-regmap
driver, because ALSA SoC framework might call it.
To fix this regression, this patch back .read/.write
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/codecs/uda1380.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/uda1380.c b/sound/soc/codecs/uda1380.c
index 46a495b..c73e6a1 100644
--- a/sound/soc/codecs/uda1380.c
+++ b/sound/soc/codecs/uda1380.c
@@ -726,6 +726,8 @@ static int uda1380_probe(struct snd_soc_codec *codec)
static const struct snd_soc_codec_driver soc_codec_dev_uda1380 = {
.probe = uda1380_probe,
+ .read = uda1380_read_reg_cache,
+ .write = uda1380_write,
.set_bias_level = uda1380_set_bias_level,
.suspend_bias_off = true,
--
1.9.1
next prev parent reply other threads:[~2018-01-16 1:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 1:58 ASoC: fix regression by adding back .read/.write Kuninori Morimoto
2018-01-16 1:59 ` [PATCH] ASoC: tlv320dac33: " Kuninori Morimoto
2018-01-16 13:56 ` Applied "ASoC: tlv320dac33: fix regression by adding back .read/.write" to the asoc tree Mark Brown
2018-01-16 1:59 ` Kuninori Morimoto [this message]
2018-01-16 13:56 ` Applied "ASoC: uda1380: " Mark Brown
2018-01-16 2:00 ` [PATCH] ASoC: cx20442: fix regression by adding back .read/.write Kuninori Morimoto
2018-01-16 13:56 ` Applied "ASoC: cx20442: fix regression by adding back .read/.write" to the asoc tree Mark Brown
2018-01-16 2:00 ` [PATCH] ASoC: add Component level .read/.write Kuninori Morimoto
2018-01-16 13:55 ` Applied "ASoC: add Component level .read/.write" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3ky8sz2.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.