From: Rusty Russell <rusty@rustcorp.com.au>
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough
Date: Wed, 04 Jul 2012 15:54:26 +0930 [thread overview]
Message-ID: <87y5n0ujqd.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1341321577-24435-1-git-send-email-pbonzini@redhat.com>
On Tue, 3 Jul 2012 15:19:37 +0200, Paolo Bonzini <pbonzini@redhat.com> wrote:
> This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature,
> which exposes the cache mode in the configuration space and lets the
> driver modify it. The cache mode is exposed via sysfs.
>
> Even if the host does not support the new feature, the cache mode is
> visible (thanks to the existing VIRTIO_BLK_F_WCE), but not modifiable.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Fixed up some checkpatch warnings for you, too:
virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:51: WARNING: please, no spaces at the start of a line
#51: FILE: drivers/block/virtio_blk.c:424:
+ revalidate_disk(vblk->disk);$
.virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:54: WARNING: static const char * array should probably be static const char * const
#54: FILE: drivers/block/virtio_blk.c:427:
+static const char *virtblk_cache_types[] = {
.virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:160: ERROR: code indent should use tabs where possible
#160: FILE: include/linux/virtio_blk.h:73:
+ /* writeback mode (if VIRTIO_BLK_F_CONFIG_WCE) */$
.virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:161: ERROR: code indent should use tabs where possible
#161: FILE: include/linux/virtio_blk.h:74:
+ __u8 wce;$
.virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:161: WARNING: please, no spaces at the start of a line
#161: FILE: include/linux/virtio_blk.h:74:
+ __u8 wce;$
total: 2 errors, 3 warnings, 132 lines checked
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-04 6:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:19 [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough Paolo Bonzini
2012-07-04 5:55 ` Rusty Russell
2012-07-04 6:24 ` Rusty Russell [this message]
2012-07-04 15:13 ` Michael S. Tsirkin
2012-07-04 15:42 ` Michael S. Tsirkin
2012-07-04 15:42 ` Michael S. Tsirkin
2012-07-04 15:54 ` Paolo Bonzini
2012-07-04 16:02 ` Michael S. Tsirkin
2012-07-04 16:02 ` Michael S. Tsirkin
2012-07-04 16:08 ` Paolo Bonzini
2012-07-04 16:08 ` Paolo Bonzini
2012-07-04 21:30 ` Michael S. Tsirkin
2012-07-04 21:30 ` Michael S. Tsirkin
2012-07-05 6:45 ` Paolo Bonzini
2012-07-05 6:45 ` Paolo Bonzini
2012-07-04 15:54 ` Paolo Bonzini
2012-07-04 16:26 ` Sasha Levin
2012-07-04 16:32 ` Paolo Bonzini
2012-07-04 21:11 ` Sasha Levin
2012-07-05 6:47 ` Paolo Bonzini
2012-07-05 7:02 ` Sasha Levin
2012-07-08 23:45 ` Rusty Russell
2012-07-25 1:02 ` Rusty Russell
2012-07-05 18:39 ` Badari Pulavarty
2012-07-06 6:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5n0ujqd.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.