From: Felipe Balbi <balbi@kernel.org>
To: Jack Pham <jackp@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-usb@vger.kernel.org, Wesley Cheng <wcheng@codeaurora.org>,
Baolin Wang <baolin.wang7@gmail.com>,
Jack Pham <jackp@codeaurora.org>
Subject: Re: [PATCH 2/2] usb: dwc3: gadget: Rename EOPF event macros to Suspend
Date: Fri, 30 Apr 2021 11:37:06 +0300 [thread overview]
Message-ID: <87zgxgi2x9.fsf@kernel.org> (raw)
In-Reply-To: <20210428090111.3370-2-jackp@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
Jack Pham <jackp@codeaurora.org> writes:
> The device event corresponding to End of Periodic Frame is only
> found on older IP revisions (2.10a and prior, according to a
> cursory SNPS databook search). On revisions 2.30a and newer,
> including DWC3.1, the same event value and corresponding DEVTEN
> bit were repurposed to indicate that the link has gone into
> suspend state (U3 or L2/L1).
>
> EOPF events had never been enabled before in this driver, and
> going forward we expect current and future DWC3-based devices
> won't likely to be using such old DWC3 IP revisions either.
> Hence rather than keeping the deprecated EOPF macro names let's
> rename them to indicate their usage for suspend events.
>
> Signed-off-by: Jack Pham <jackp@codeaurora.org>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-04-30 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 9:01 [PATCH 1/2] usb: dwc3: gadget: Enable suspend events Jack Pham
2021-04-28 9:01 ` [PATCH 2/2] usb: dwc3: gadget: Rename EOPF event macros to Suspend Jack Pham
2021-04-28 10:28 ` Felipe Balbi
2021-04-28 15:50 ` Jack Pham
2021-04-29 2:39 ` Thinh Nguyen
2021-04-30 8:37 ` Felipe Balbi [this message]
2021-04-28 10:19 ` [PATCH 1/2] usb: dwc3: gadget: Enable suspend events Felipe Balbi
2021-04-28 15:34 ` Jack Pham
2021-04-30 8:39 ` Felipe Balbi
2021-04-30 8:39 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgxgi2x9.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=baolin.wang7@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-usb@vger.kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.