From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [2/3] ath10k: Fix napi related crash when otp fails.
Date: Thu, 1 Jun 2017 13:10:46 +0000 [thread overview]
Message-ID: <87zidrlupz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <33cae296-755f-a60a-85fd-18b1441a01fd@candelatech.com> (Ben Greear's message of "Wed, 31 May 2017 06:11:51 -0700")
Ben Greear <greearb@candelatech.com> writes:
>> Doesn't the commit below fix this?
>
> I don't know, but the problem in my case is that napi wasn't properly stopped,
> and the patch you reference is just about starting napi earlier, right?
IIRC I moved it to a different function which was called later. This was
just to match the symmetry with napi_disable() and fix the error
handling.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-06-01 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 21:25 [PATCH 1/3] ath10k: Increase BMI timeout greearb
2017-05-15 21:25 ` [PATCH 2/3] ath10k: Fix napi related crash when otp fails greearb
2017-05-31 12:27 ` [2/3] " Kalle Valo
2017-05-31 13:11 ` Ben Greear
2017-06-01 13:10 ` Kalle Valo [this message]
2017-05-15 21:25 ` [PATCH 3/3] ath10k: Log when longer bmi cmds happen greearb
2017-05-31 12:46 ` [3/3] " Kalle Valo
2017-05-31 13:00 ` Ben Greear
2017-06-01 12:56 ` [1/3] ath10k: Increase BMI timeout Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zidrlupz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.