Re: [PATCH] drm/i915: Unset cursor if out-of-bounds upon mode change (v2)

From: Eric Anholt <eric@anholt.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Christopher James Halse Rogers
	<christopher.halse.rogers@canonical.com>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
Subject: Re: [PATCH] drm/i915: Unset cursor if out-of-bounds upon mode change (v2)
Date: Thu, 08 Jul 2010 11:27:14 -0700	[thread overview]
Message-ID: <87zky1bzi5.fsf@pollan.anholt.net> (raw)
In-Reply-To: <89k77n$oa91s8@fmsmga001.fm.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

On Thu, 08 Jul 2010 14:23:26 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, 08 Jul 2010 22:56:34 +1000, Christopher James Halse Rogers <christopher.halse.rogers@canonical.com> wrote:
> > The 965 docs say (vol 3, p142, 147) that CUR?BASE should be written to
> > last when updating any of the cursor regs even if the base value hasn't
> > changed to trigger an update on the next VBLANK.
> > 
> > I'm not sure whether my reading of that documentation is correct,
> > though, because the cursor seemed to update just fine with the code in
> > this patch.
> 
> CUR?POS:
> "This register can be loaded atomically (requires that the base address be
> written) and is double buffered."
> 
> As the code has been previously moving the cursor for many years without
> updating CUR?BASE, I think we are safe.
> -ickle

Cursors are working fine on my system with this patch, but I'll wait for
a resolution on the regression when cursor at top/left.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx