From: Andreas Dilger <adilger@dilger.ca>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Drop ext4_journal_free_reserved()
Date: Wed, 20 May 2020 13:29:01 -0600 [thread overview]
Message-ID: <880DF805-D78D-427A-A53F-FD8CFB00B5E3@dilger.ca> (raw)
In-Reply-To: <20200520133119.1383-2-jack@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On May 20, 2020, at 7:31 AM, Jan Kara <jack@suse.cz> wrote:
>
> Remove ext4_journal_free_reserved() function. It is never used.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/ext4_jbd2.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
> index 4b9002f0e84c..1c926f31d43e 100644
> --- a/fs/ext4/ext4_jbd2.h
> +++ b/fs/ext4/ext4_jbd2.h
> @@ -335,12 +335,6 @@ static inline handle_t *__ext4_journal_start(struct inode *inode,
> handle_t *__ext4_journal_start_reserved(handle_t *handle, unsigned int line,
> int type);
>
> -static inline void ext4_journal_free_reserved(handle_t *handle)
> -{
> - if (ext4_handle_valid(handle))
> - jbd2_journal_free_reserved(handle);
> -}
> -
> static inline handle_t *ext4_journal_current_handle(void)
> {
> return journal_current_handle();
> --
> 2.16.4
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2020-05-20 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:31 [PATCH 0/2 v2] jbd2: Fix leaked transaction credits Jan Kara
2020-05-20 13:31 ` [PATCH 1/2] ext4: Drop ext4_journal_free_reserved() Jan Kara
2020-05-20 19:29 ` Andreas Dilger [this message]
2020-05-29 2:43 ` Theodore Y. Ts'o
2020-05-20 13:31 ` [PATCH 2/2] jbd2: Avoid leaking transaction credits when unreserving handle Jan Kara
2020-05-29 2:44 ` Theodore Y. Ts'o
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 9:21 [PATCH 0/2] jbd2: Fix leaked transaction credits Jan Kara
2020-05-18 9:21 ` [PATCH 1/2] ext4: Drop ext4_journal_free_reserved() Jan Kara
2020-05-19 1:55 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880DF805-D78D-427A-A53F-FD8CFB00B5E3@dilger.ca \
--to=adilger@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.