Re: [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request

From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request
Date: Fri, 23 Aug 2019 11:41:08 -0500	[thread overview]
Message-ID: <8865962e-ddb9-eb40-715e-3d6756c1af80@redhat.com> (raw)
In-Reply-To: <20190823143726.27062-6-eblake@redhat.com>

[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]

[dropping non-qemu lists]

On 8/23/19 9:37 AM, Eric Blake wrote:
> A server may have a reason to reject a request for structured replies,
> beyond just not recognizing them as a valid request.  It doesn't hurt
> us to continue talking to such a server; otherwise 'qemu-nbd --list'
> of such a server fails to display all possible details about the
> export.
> 
> Encountered when temporarily tweaking nbdkit to reply with
> NBD_REP_ERR_POLICY.  Present since structured reply support was first
> added (commit d795299b reused starttls handling, but starttls has to
> reject all errors).
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  nbd/client.c | 39 +++++++++++++++++++++++----------------
>  1 file changed, 23 insertions(+), 16 deletions(-)

Shoot, I included one patch too many. This patch was posted in a
separate thread, where I argued that it is broken and needs a v2:

https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04323.html

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]