All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhuyinbo <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
	wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
	loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
Subject: Re: [PATCH v5 1/2] dt-bindings: spi: add loongson spi
Date: Fri, 31 Mar 2023 18:41:04 +0800	[thread overview]
Message-ID: <8881d54c-62e0-510b-e2d4-3f1b035f8084@loongson.cn> (raw)
In-Reply-To: <7d9e1d19-10e0-a627-bf1f-a42e7d936dcf@linaro.org>



在 2023/3/31 下午5:44, Krzysztof Kozlowski 写道:
> On 31/03/2023 05:29, Yinbo Zhu wrote:
>> Add the Loongson platform spi binding with DT schema format using
>> json-schema.
> 
> 
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - loongson,ls2k-spi
>> +      - loongson,ls7a-spi
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/loongson,ls2k-clk.h>
> 
> Why do you need the header? Wasn't the entire point to remove it?
okay, I got it, I will remove this head file.

Thanks.
> 
>> +    spi0: spi@1fff0220{
>> +        compatible = "loongson,ls2k-spi";
>> +        reg = <0x1fff0220 0x10>;
>> +        clocks = <&clk 17>;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +    };
> 
> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2023-03-31 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  3:29 [PATCH v5 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-03-31  3:29 ` [PATCH v5 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-31  9:44   ` Krzysztof Kozlowski
2023-03-31 10:41     ` zhuyinbo [this message]
2023-03-31  3:29 ` [PATCH v5 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8881d54c-62e0-510b-e2d4-3f1b035f8084@loongson.cn \
    --to=zhuyinbo@loongson.cn \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=liupeibao@loongson.cn \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=lvjianmin@loongson.cn \
    --cc=robh+dt@kernel.org \
    --cc=wanghongliang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.