From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
Date: Fri, 23 Nov 2018 10:55:49 +0100 [thread overview]
Message-ID: <88dfd2f5-636b-7089-2945-5b62f98d43cd@redhat.com> (raw)
In-Reply-To: <20181123090058.6931-1-rkagan@virtuozzo.com>
On 23/11/18 10:01, Roman Kagan wrote:
> elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> set anywhere.
>
> The original intent was presumably to skip building it on Windows, so
> check for "$mingw32" = "no" instead.
>
> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0a3c6a72c3..fc6ce0065d 100755
> --- a/configure
> +++ b/configure
> @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> if [ "$ivshmem" = "yes" ]; then
> tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> fi
> - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> tools="elf2dmp $tools"
> fi
> fi
>
next prev parent reply other threads:[~2018-11-23 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 9:01 [Qemu-devel] [PATCH] configure: fix elf2dmp check Roman Kagan
2018-11-23 9:55 ` Philippe Mathieu-Daudé [this message]
2018-11-23 16:34 ` Paolo Bonzini
2018-11-27 18:50 ` Paolo Bonzini
2018-11-27 19:31 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88dfd2f5-636b-7089-2945-5b62f98d43cd@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=viktor.prutyanov@phystech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.