From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, bijan.mottahedeh@oracle.com, maz@kernel.org
Subject: Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime
Date: Wed, 9 Oct 2019 20:50:02 -0400 [thread overview]
Message-ID: <892976b9-0e43-940d-1d36-046749d652c9@linaro.org> (raw)
In-Reply-To: <20191007170622.1814-4-drjones@redhat.com>
On 10/7/19 1:06 PM, Andrew Jones wrote:
> +static void kvm_arm_vm_state_change(void *opaque, int running, RunState state)
> +{
> + CPUState *cs = opaque;
> + ARMCPU *cpu = ARM_CPU(cs);
> +
> + if (running) {
> + if (cpu->kvm_adjvtime) {
> + kvm_arm_set_virtual_time(cs);
> + }
> + }
> +}
Worth putting this in kvm.c too, so you don't have to duplicate it? You can
always split it apart later if you ever do need a different hook for 32 vs 64.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-10-10 0:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:06 [RFC PATCH 0/5] target/arm/kvm: Provide an option to adjust virtual time Andrew Jones
2019-10-07 17:06 ` [RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers Andrew Jones
2019-10-10 0:45 ` Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq Andrew Jones
2019-10-10 0:45 ` Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime Andrew Jones
2019-10-10 0:50 ` Richard Henderson [this message]
2019-10-10 6:29 ` Andrew Jones
2019-10-07 17:06 ` [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values Andrew Jones
2019-10-10 0:51 ` Richard Henderson
2019-10-07 17:06 ` [RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property Andrew Jones
2019-10-10 0:53 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892976b9-0e43-940d-1d36-046749d652c9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bijan.mottahedeh@oracle.com \
--cc=drjones@redhat.com \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.