From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v4 4/4] clk: qcom: lpass: Add support for LPASS clock controller for SC7180
Date: Fri, 24 Jul 2020 21:36:53 +0530 [thread overview]
Message-ID: <893b1221-6e35-a903-77d4-a60a3ce0cbdc@codeaurora.org> (raw)
In-Reply-To: <159531768310.3847286.13203525525881212775@swboyd.mtv.corp.google.com>
Hi Stephen,
Thanks for the review.
On 7/21/2020 1:18 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-07-14 23:36:50)
>> diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c
>> +static struct clk_alpha_pll lpass_lpaaudio_dig_pll = {
>> + .offset = 0x1000,
>> + .vco_table = fabia_vco,
>> + .num_vco = ARRAY_SIZE(fabia_vco),
>> + .regs = clk_alpha_pll_regs_offset[CLK_ALPHA_PLL_TYPE_FABIA],
>> + .clkr = {
>> + .hw.init = &(struct clk_init_data){
>> + .name = "lpass_lpaaudio_dig_pll",
>> + .parent_data = &(const struct clk_parent_data){
>> + .fw_name = "bi_tcxo",
>> + .name = "bi_tcxo",
>
> We don't need .name if we have .fw_name and this is a new binding/device.
>
My bad, will cleanup in the next patch.
>> + },
>> + .num_parents = 1,
>> + .ops = &clk_alpha_pll_fabia_ops,
>> + },
>> + },
>> +};
>> +
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
prev parent reply other threads:[~2020-07-24 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 6:36 [PATCH v4 0/4] clk: qcom: Support for Low Power Audio Clocks on SC7180 Taniya Das
2020-07-15 6:36 ` [PATCH v4 1/4] clk: qcom: gdsc: Add support to enable retention of GSDCR Taniya Das
2020-07-15 6:36 ` [PATCH v4 2/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180 Taniya Das
2020-07-16 19:06 ` Rob Herring
2020-07-21 7:51 ` Stephen Boyd
2020-07-21 17:26 ` Taniya Das
2020-07-23 1:05 ` Stephen Boyd
2020-07-15 6:36 ` [PATCH v4 3/4] clk: qcom: gcc: Add support for GCC LPASS clock for SC7180 Taniya Das
2020-07-15 6:36 ` [PATCH v4 4/4] clk: qcom: lpass: Add support for LPASS clock controller " Taniya Das
2020-07-21 7:48 ` Stephen Boyd
2020-07-24 16:06 ` Taniya Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893b1221-6e35-a903-77d4-a60a3ce0cbdc@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.