From: Nikita Travkin <nikita@trvn.ru>
To: Dang Huynh <danct12@riseup.net>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: aw2013: Select REGMAP_I2C
Date: Fri, 03 Nov 2023 16:59:24 +0500 [thread overview]
Message-ID: <89a873f8f9156221faee9fa3ecb3e3e5@trvn.ru> (raw)
In-Reply-To: <20231103114203.1108922-1-danct12@riseup.net>
Dang Huynh писал(а) 03.11.2023 16:42:
> The AW2013 driver uses devm_regmap_init_i2c, so REGMAP_I2C needs to
> be selected.
>
> Otherwise build process may fail with:
> ld: drivers/leds/leds-aw2013.o: in function `aw2013_probe':
> leds-aw2013.c:345: undefined reference to `__devm_regmap_init_i2c'
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
Oh, thanks for noticing that!
Acked-by: Nikita Travkin <nikita@trvn.ru>
Btw for fixes like this it's customary to add a Fixes tag
to let stable team know they might want to backport it:
Fixes: 59ea3c9faf32 ("leds: add aw2013 driver")
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b92208eccdea..3132439f99e0 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -110,6 +110,7 @@ config LEDS_AW200XX
> config LEDS_AW2013
> tristate "LED support for Awinic AW2013"
> depends on LEDS_CLASS && I2C && OF
> + select REGMAP_I2C
> help
> This option enables support for the AW2013 3-channel
> LED driver.
next prev parent reply other threads:[~2023-11-03 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 11:42 [PATCH] leds: aw2013: Select REGMAP_I2C Dang Huynh
2023-11-03 11:59 ` Nikita Travkin [this message]
2023-11-23 10:59 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a873f8f9156221faee9fa3ecb3e3e5@trvn.ru \
--to=nikita@trvn.ru \
--cc=danct12@riseup.net \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.