From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Nicholas Piggin <npiggin@gmail.com>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, Anton Blanchard <anton@ozlabs.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] Increase page and bit waitqueue hash size
Date: Wed, 17 Mar 2021 11:12:44 +0100 [thread overview]
Message-ID: <89cb49c0-2736-dd4c-f401-4b88c22cc11f@rasmusvillemoes.dk> (raw)
In-Reply-To: <20210317075427.587806-1-npiggin@gmail.com>
On 17/03/2021 08.54, Nicholas Piggin wrote:
> +#if CONFIG_BASE_SMALL
> +static const unsigned int page_wait_table_bits = 4;
> static wait_queue_head_t page_wait_table[PAGE_WAIT_TABLE_SIZE] __cacheline_aligned;
>
> + if (!CONFIG_BASE_SMALL) {
> + page_wait_table = alloc_large_system_hash("page waitqueue hash",
> + sizeof(wait_queue_head_t),
> + 0,
So, how does the compiler not scream at you for assigning to an array,
even if it's inside an if (0)?
Rasmus
next prev parent reply other threads:[~2021-03-17 10:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 7:54 [PATCH v2] Increase page and bit waitqueue hash size Nicholas Piggin
2021-03-17 8:38 ` Ingo Molnar
2021-03-17 10:02 ` Nicholas Piggin
2021-03-17 10:12 ` Rasmus Villemoes [this message]
2021-03-17 10:44 ` Nicholas Piggin
2021-03-17 19:26 ` Linus Torvalds
2021-03-17 19:26 ` Linus Torvalds
2021-03-17 22:22 ` Nicholas Piggin
2021-03-17 23:13 ` Linus Torvalds
2021-03-17 23:13 ` Linus Torvalds
2021-03-17 11:25 ` kernel test robot
2021-03-17 11:25 ` kernel test robot
2021-03-17 11:30 ` kernel test robot
2021-03-17 11:30 ` kernel test robot
2021-03-17 12:38 ` [tip: sched/core] sched/wait_bit, mm/filemap: " tip-bot2 for Nicholas Piggin
2021-03-17 15:16 ` Thomas Gleixner
2021-03-17 19:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89cb49c0-2736-dd4c-f401-4b88c22cc11f@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=anton@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.