Re: [kvm-unit-tests PATCH v3 0/9] x86: n{VMX,SVM} exception tests

From: Manali Shukla <manali.shukla@amd.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3 0/9] x86: n{VMX,SVM} exception tests
Date: Wed, 12 Oct 2022 09:47:00 +0530	[thread overview]
Message-ID: <89e66c8d-7f41-3151-75b2-2670fc3493cf@amd.com> (raw)
In-Reply-To: <20221005235212.57836-1-seanjc@google.com>

On 10/6/2022 5:22 AM, Sean Christopherson wrote:
> This is a continuation of Manali's series[*] to add nSVM exception routing
> tests.  The functionality is largely the same, but instead of copy+pasting
> nVMX tests (and vice versa), move the helpers that generate exceptions to
> processor.h so that at least the gory details can be shared.
> 
> An added bonus is that by consolidating code, nVMX can do some of the same
> cleanups that Manali's patches do for nSVM, e.g. move more testcases to
> the generic framework and drop fully redundant tests.
> 
> https://lore.kernel.org/all/20220810050738.7442-1-manali.shukla@amd.com
> 
> Manali Shukla (4):
>   x86: nSVM: Add an exception test framework and tests
>   x86: nSVM: Move #BP test to exception test framework
>   x86: nSVM: Move #OF test to exception test framework
>   x86: nSVM: Move part of #NM test to exception test framework
> 
> Sean Christopherson (5):
>   nVMX: Add "nop" after setting EFLAGS.TF to guarantee single-step #DB
>   x86: Move helpers to generate misc exceptions to processor.h
>   nVMX: Move #OF test to generic exceptions test
>   nVMX: Drop one-off INT3=>#BP test
>   nVMX: Move #NM test to generic exception test framework
> 
>  lib/x86/processor.h |  97 ++++++++++++++++++++
>  x86/svm_tests.c     | 195 ++++++++++++++++++----------------------
>  x86/vmx_tests.c     | 214 ++++++--------------------------------------
>  3 files changed, 210 insertions(+), 296 deletions(-)
> 
> 
> base-commit: d8a4f9e5e8d69d4ef257b40d6cd666bd2f63494e

Hi Sean,

Thank you for reviewing my changes.
I have tested the changes on AMD Milan/Napples and it works as expected.

-Manali