Re: [PATCH] drm/agp/i915: trim stolen space to 32M

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Simon Farnsworth <simon.farnsworth@onelan.com>,
	intel-gfx@lists.freedesktop.org
Cc: t.artem@mailcity.com
Subject: Re: [PATCH] drm/agp/i915: trim stolen space to 32M
Date: Thu, 08 Jul 2010 17:42:19 +0100	[thread overview]
Message-ID: <89k77n$oab77c@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <201007081737.10942.simon.farnsworth@onelan.com>

On Thu, 8 Jul 2010 17:37:10 +0100, Simon Farnsworth <simon.farnsworth@onelan.com> wrote:
> On Thursday 8 July 2010, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Some BIOSes will claim a large chunk of stolen space.  Unless we
> > reclaim it, our aperture for remapping buffer objects will be
> > constrained.  So clamp the stolen space to 32M and ignore the rest.
> > 
> > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15469 among others.
> > 
> > Adding the ignored stolen memory back into the general pool using the
> > memory hotplug code is left as an exercise for the reader.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> FWIW, given how simple the code actually is:
> Reviewed-by: Simon Farnsworth <simon.farnsworth@onelan.com>

Heh, you were meant to say:

"What? Export a magic parameter from intel-gtt.c to indicate how much
space to remove from the aperture guestimate, but not replace the *broken*
code in i915_dma.c with an interface from intel-gtt.c to query and control
the populated GTT more precisely?"

;-)
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre