From: Christoph Fritz <chf.fritz@googlemail.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages setting
Date: Tue, 18 May 2021 14:00:25 +0200 [thread overview]
Message-ID: <8a8fad66288f38a3dacd5dc23cee62bf3e3e6d5f.camel@googlemail.com> (raw)
In-Reply-To: <20210517105325.1227393-1-axel.lin@ingics.com>
On Mon, 2021-05-17 at 18:53 +0800, Axel Lin wrote:
> Fixes: e6dea51e2d41 ("regulator: fan53880: Add initial support")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
> v2: address Christoph' comment
> drivers/regulator/fan53880.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c
> index e83eb4fb1876..1684faf82ed2 100644
> --- a/drivers/regulator/fan53880.c
> +++ b/drivers/regulator/fan53880.c
> @@ -51,6 +51,7 @@ static const struct regulator_ops fan53880_ops = {
> REGULATOR_LINEAR_RANGE(800000, 0xf, 0x73, 25000), \
> }, \
> .n_linear_ranges = 2, \
> + .n_voltages = 0x74, \
> .vsel_reg = FAN53880_LDO ## _num ## VOUT, \
> .vsel_mask = 0x7f, \
> .enable_reg = FAN53880_ENABLE, \
> @@ -76,6 +77,7 @@ static const struct regulator_desc
> fan53880_regulators[] = {
> REGULATOR_LINEAR_RANGE(600000, 0x1f, 0xf7, 12500),
> },
> .n_linear_ranges = 2,
> + .n_voltages = 0xf8,
> .vsel_reg = FAN53880_BUCKVOUT,
> .vsel_mask = 0x7f,
> .enable_reg = FAN53880_ENABLE,
> @@ -95,6 +97,7 @@ static const struct regulator_desc
> fan53880_regulators[] = {
> REGULATOR_LINEAR_RANGE(3000000, 0x4, 0x70, 25000),
> },
> .n_linear_ranges = 2,
> + .n_voltages = 0x71,
> .vsel_reg = FAN53880_BOOSTVOUT,
> .vsel_mask = 0x7f,
> .enable_reg = FAN53880_ENABLE_BOOST,
next prev parent reply other threads:[~2021-05-18 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 10:53 [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages setting Axel Lin
2021-05-17 10:53 ` [PATCH v2 2/2] regulator: fan53880: Convert to use .probe_new Axel Lin
2021-05-18 12:00 ` Christoph Fritz
2021-05-18 12:00 ` Christoph Fritz [this message]
2021-05-18 16:31 ` [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages setting Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a8fad66288f38a3dacd5dc23cee62bf3e3e6d5f.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.